Skip to content

[Deepin-Kernel-SIG] [linux 6.6-y] [Huawei] net/hinic3: drivers/new/ethernet/huawei: Modify the driver version #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2025

Conversation

Avenger-285714
Copy link
Collaborator

@Avenger-285714 Avenger-285714 commented Jun 27, 2025

Modify the driver version.

Link: https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel/pulls/422

Summary by Sourcery

Bump the Huawei HINIC3 Ethernet driver version to reflect the latest release

Chores:

  • Update HINIC3 driver version from 17.7.8.1 to 17.7.8.101 in CRM header
  • Update HINIC3 NIC driver version from 17.7.8.1 to 17.7.8.101 in NIC device header

@Avenger-285714 Avenger-285714 requested review from opsiff and Copilot June 27, 2025 22:58
Copy link

sourcery-ai bot commented Jun 27, 2025

Reviewer's Guide

Update the HINIC3 driver version macros to the new release number across relevant header files.

File-Level Changes

Change Details Files
Bump HINIC3 driver version to 17.7.8.101
  • Replace HINIC3_DRV_VERSION value
  • Replace HINIC3_NIC_DRV_VERSION value
drivers/net/ethernet/huawei/hinic3/hinic3_crm.h
drivers/net/ethernet/huawei/hinic3/hinic3_nic_dev.h

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the driver version for the Huawei hinic3 network driver. The changes update the version macros in both the device header and CRM header files to reflect the new version.

  • Updated HINIC3_NIC_DRV_VERSION in hinic3_nic_dev.h
  • Updated HINIC3_DRV_VERSION in hinic3_crm.h

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
drivers/net/ethernet/huawei/hinic3/hinic3_nic_dev.h Updated driver version macro to "17.7.8.101"
drivers/net/ethernet/huawei/hinic3/hinic3_crm.h Updated driver version macro to "17.7.8.101"
Comments suppressed due to low confidence (2)

drivers/net/ethernet/huawei/hinic3/hinic3_nic_dev.h:21

  • Ensure that the updated driver version is referenced in the corresponding release notes and documentation to maintain version consistency across the project.
#define HINIC3_NIC_DRV_VERSION	"17.7.8.101"

drivers/net/ethernet/huawei/hinic3/hinic3_crm.h:11

  • Verify that this version update is synchronized with other driver components and that any public facing version references are updated accordingly.
#define HINIC3_DRV_VERSION "17.7.8.101"

@Avenger-285714 Avenger-285714 changed the title [Deepin-Kernel-SIG] [linux 6.6-y] [Huawei] net/hinic3:: drivers/new/ethernet/huawei: Modify the driver version [Deepin-Kernel-SIG] [linux 6.6-y] [Huawei] net/hinic3: drivers/new/ethernet/huawei: Modify the driver version Jun 27, 2025
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. 版本号更新:

    • hinic3_crm.hhinic3_nic_dev.h文件中,版本号从17.7.8.1更新到了17.7.8.101。这是一个合理的版本号更新,表示软件进行了重要的更新或修复。确保这一更新与实际的功能变化或修复相匹配。
  2. 文件修改:

    • 两个头文件中的版本号被更新,这通常意味着相关的驱动程序代码已经发生了变化。需要检查是否有相应的代码更新与版本号更新相匹配,并且这些更新已经通过了充分的测试。
  3. 代码质量:

    • 版本号的更新本身没有明显的代码质量问题,但是建议在更新版本号时,同时更新相关的文档和发布说明,确保用户和开发者能够清楚地了解版本的变化。
  4. 代码性能:

    • 版本号的更新不会直接影响代码的性能,但是确保版本号与实际的功能变化相匹配对于维护和优化代码性能至关重要。
  5. 代码安全:

    • 版本号的更新不会直接影响代码的安全性,但是确保版本号与安全修复相匹配对于维护软件的安全至关重要。

总体来说,这个提交主要是关于版本号的更新,没有引入新的代码逻辑或修改,因此没有明显的语法或逻辑错误。但是,建议进行全面的测试以确保版本更新不会引入任何问题,并且确保文档和发布说明与版本更新保持一致。

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Avenger-285714 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@opsiff opsiff merged commit 0748470 into deepin-community:linux-6.6.y Jun 29, 2025
8 of 9 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: opsiff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants