Skip to content

[Deepin-Kernel-SIG] [linux 6.12-y] [Upstream] x86: configs: reenable CONFIG_DEBUG_INFO_BTF and enable some snd soc #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

opsiff
Copy link
Member

@opsiff opsiff commented Jul 9, 2025

Link: https://bbs.deepin.org.cn/post/289237
Fixes: 775a1884d2e7 ("x86: configs: enable BT_INTEL_PCIE")

Summary by Sourcery

Restore BTF debug info support and enable additional SoC sound drivers in the Deepin x86 desktop defconfig.

New Features:

  • Enable multiple SND_SOC sound SoC drivers in the x86 desktop defconfig

Bug Fixes:

  • Re-enable CONFIG_DEBUG_INFO_BTF to restore BTF debug info support

Copy link

sourcery-ai bot commented Jul 9, 2025

Reviewer's Guide

This PR updates the X86 desktop defconfig to reenable BTF debug‐info support and turn on several SoC audio drivers, aligning the Deepin kernel config with recent upstream defaults.

File-Level Changes

Change Details Files
Reenable BTF-based debug info
  • Removed the “not set” override for CONFIG_DEBUG_INFO_BTF
  • Added CONFIG_DEBUG_INFO_BTF=y to enable BTF metadata generation
arch/x86/configs/deepin_x86_desktop_defconfig
Enable additional ASoC (ALSA System-on-Chip) drivers
  • Added support for Intel SOF firmware integration
  • Enabled various Intel/SoundWire codec drivers
  • Turned on matching module config symbols for on-board audio
arch/x86/configs/deepin_x86_desktop_defconfig

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. 新增配置项的注释:建议在新增的配置项 CONFIG_SND_SOC_INTEL_AVS_MACH_RT5514=mCONFIG_SND_SOC_INTEL_HASWELL_MACH=mCONFIG_SND_SOC_INTEL_BDW_RT5650_MACH=mCONFIG_SND_SOC_INTEL_BDW_RT5677_MACH=mCONFIG_SND_SOC_INTEL_BROADWELL_MACH=m 后面添加注释,说明这些配置项的作用和用途,以便其他开发者理解这些更改的目的。

  2. 配置项的命名一致性:检查新增的配置项命名是否与现有配置项保持一致,特别是命名风格和前缀。如果可能,确保所有配置项的命名遵循相同的约定。

  3. 配置项的依赖性:确认新增的配置项是否有依赖关系,例如是否需要其他配置项的启用。如果有依赖关系,应该在配置文件中明确指出。

  4. 调试信息配置项:新增的 CONFIG_DEBUG_INFO_BTF=yCONFIG_MODULE_ALLOW_BTF_MISMATCH=y 配置项与调试信息相关。确保这些配置项的启用不会对系统性能产生负面影响,并且不会泄露敏感信息。

  5. 代码风格和格式:检查整个配置文件,确保代码风格和格式与项目中的其他文件保持一致。例如,检查缩进、空格和换行符的使用。

  6. 配置项的默认值:确认新增的配置项是否具有合理的默认值,并且这些默认值不会对系统产生不期望的影响。

  7. 安全性:虽然配置文件本身不太可能直接涉及安全性问题,但确保任何新增的配置项不会引入安全漏洞,特别是如果这些配置项与网络连接或外部设备交互。

  8. 测试:建议在合并这些更改之前,进行充分的测试,以确保新增的配置项不会影响系统的稳定性和性能。

综上所述,虽然这次提交的改动相对较小,但仍然需要注意细节,确保代码的质量和一致性。

@Avenger-285714 Avenger-285714 merged commit 9edae1e into deepin-community:linux-6.12.y Jul 9, 2025
5 of 6 checks passed
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-enables BTF debug info and adds several Intel SoC sound driver options to the Deepin x86 desktop defconfig.

  • Re-enable CONFIG_DEBUG_INFO_BTF and allow BTF module mismatches
  • Enable additional Intel SND_SOC machine driver options (RT5514, Haswell, Broadwell, etc.)
Comments suppressed due to low confidence (1)

arch/x86/configs/deepin_x86_desktop_defconfig:5694

  • [nitpick] Add a brief comment explaining why BTF mismatches are allowed to clarify the rationale for future maintainers.
CONFIG_MODULE_ALLOW_BTF_MISMATCH=y

@@ -3599,10 +3599,15 @@ CONFIG_SND_SOC_INTEL_AVS_MACH_PROBE=m
CONFIG_SND_SOC_INTEL_AVS_MACH_RT274=m
CONFIG_SND_SOC_INTEL_AVS_MACH_RT286=m
CONFIG_SND_SOC_INTEL_AVS_MACH_RT298=m
CONFIG_SND_SOC_INTEL_AVS_MACH_RT5514=m
Copy link
Preview

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The new SoC entries (RT5514, Haswell, Broadwell, etc.) are interleaved with existing AVS entries and interrupt the alphabetical grouping; consider grouping all Intel SND_SOC driver configs by chipset family for clarity.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants