Skip to content

feat: support pipeline_output_type [DC-4216] #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025

Conversation

faymarie
Copy link
Contributor

Related Issues

Proposed Changes?

How did you test it?

Notes for the reviewer

Screenshots (optional)

Checklist

  • I have updated the referenced issue with new insights and changes
  • If this is a code change, I have added unit tests
  • I've used the conventional commit specification for my PR title
  • I updated the docstrings
  • If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

@faymarie faymarie requested a review from a team as a code owner June 11, 2025 15:12
@faymarie faymarie requested a review from tstadel June 11, 2025 15:12
Copy link

github-actions bot commented Jun 11, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  deepset_cloud_sdk/workflows/pipeline_client
  models.py
  pipeline_service.py
Project Total  

This report was generated by python-coverage-comment-action

"""
)
"""
components:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some improved readability for yaml strings (also further down).

Marie-Luise Klaus added 2 commits June 11, 2025 17:18
Copy link
Member

@tstadel tstadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@faymarie faymarie added this pull request to the merge queue Jun 12, 2025
Merged via the queue into main with commit d370b98 Jun 12, 2025
9 checks passed
@faymarie faymarie deleted the feat/add-pipeline-output-type-option branch June 12, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants