Skip to content

test: Check that _convert_chat_completion_chunk_to_streaming_chunk works for MistralChatGenerator #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Jun 16, 2025

Related Issues

Proposed Changes:

  • Add unit test that each Mistral chunk is converted into the expected Haystack StreamingChunk
  • Update other tool integration tests to call two tools so the more complicated case is tested
  • Added a unit test that explicitly tests that the Mistral Chunks are properly converted into the final Haystack ChatMessage

How did you test it?

Notes for the reviewer

Checklist

@sjrl sjrl changed the title test: Check that OpenAIChatGenerator._convert_chat_completion_chunk_to_streaming_chunk works for MistralChatGenerator test: Check that _convert_chat_completion_chunk_to_streaming_chunk works for MistralChatGenerator Jun 17, 2025
@github-actions github-actions bot added the type:documentation Improvements or additions to documentation label Jun 17, 2025
@sjrl sjrl self-assigned this Jun 17, 2025
@sjrl
Copy link
Contributor Author

sjrl commented Jun 18, 2025

This is done, but putting on hold until this PR deepset-ai/haystack#9525 is merged and the next version of Haystack is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:mistral type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant