Skip to content

Update devcontainer to use Ruby 3.3 #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

mikatuo
Copy link
Contributor

@mikatuo mikatuo commented Oct 2, 2024

It looks like devcontainer setup got outdated due to the bundler version specified in Gemfile.lock

BUNDLED WITH
   2.5.14

Bundler 2.5.14 requires Ruby > 3.0 but previous Docker image for devcontainer was based on Ruby 2.7 and so the serve.sh was crashing.

Changes

  • use Ruby 3.3 (3.3.5) for devcontainer's Docker image
  • update .ruby-version to 3.3.5 - not sure if anyone runs Jekyll locally using a different Ruby version, but previously specified v2.7.5 was incorrect anyway

@mikatuo mikatuo changed the title Update devcontainer setup Update devcontainer to use Ruby 3.3 Oct 2, 2024
Copy link
Collaborator

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@britzl britzl merged commit ea4d4f3 into defold:master Oct 3, 2024
@mikatuo mikatuo deleted the update-devcontainer branch October 5, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants