-
Notifications
You must be signed in to change notification settings - Fork 22
Implemented instance type #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,4 @@ | ||
extender.gradle.enabled: true | ||
extender: | ||
instance-type: BUILDER_ONLY | ||
gradle: | ||
enabled: true |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
extender: | ||
instance-type: FRONTEND_ONLY | ||
remote-builder: | ||
enabled: true | ||
platforms: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
extender: | ||
instance-type: BUILDER_ONLY | ||
# sdk.location: /usr/local/extender/sdk | ||
cache: | ||
enabled: true | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -212,6 +212,7 @@ public void buildEngineAsync(HttpServletRequest _request, | |
} else { | ||
String[] buildEnvDescription = null; | ||
try { | ||
// sdk version was removed (dev or beta) | ||
buildEnvDescription = ExtenderUtil.getSdksForPlatform(platform, defoldSdkService.getPlatformSdkMappings(sdkVersion)); | ||
} catch(ExtenderException exc) { | ||
if (instanceType.equals(InstanceType.FRONTEND_ONLY)) { | ||
|
@@ -226,6 +227,7 @@ public void buildEngineAsync(HttpServletRequest _request, | |
} else if (instanceType.equals(InstanceType.MIXED)) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If sdk mappings exist but there are no required sdk version defined and instance marked as "MIXED" - try build on current instance. |
||
asyncBuilder.asyncBuildEngine(metricsWriter, platform, sdkVersion, jobDirectory, uploadDirectory, buildDirectory); | ||
} else { | ||
// no remote buidler was found and current instance can't build | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. buidler -> builder |
||
throw new NotSupportedException("Engine version unsupported. Please, update engine to the newer version."); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. SDK mappings exists but no record for given sdk and version was found - throw error. |
||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exception happened if we can't find sdk mappings for given hash.