feat: introduce VacuumMode::Full for cleaning up orphaned files #3368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyler
requested review from
wjones127,
roeap,
hntd187 and
ion-elgreco
as code owners
rtyler
force-pushed
the
feature/full-vacuum-engage
branch
from
d56badf to
1cc4289
Compare
auto-merge was automatically disabled
April 7, 2025 14:41
Pull request was converted to draft
rtyler
force-pushed
the
feature/full-vacuum-engage
branch
from
1cc4289 to
c734263
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3368 +/- ##
=======================================
Coverage 72.01% 72.01%
=======================================
Files 148 148
Lines 46082 46137 +55
Branches 46082 46137 +55
=======================================
+ Hits 33184 33225 +41
- Misses 10791 10794 +3
- Partials 2107 2118 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ion-elgreco
reviewed
Apr 7, 2025
crates/core/src/operations/vacuum.rs
Outdated
Comment on lines
83
to
84
| /// The `lite` mode will only remove files which are referenced in the `_delta_log` associagted | ||
| /// with `remove` action |
There was a problem hiding this comment.
The databricks docs on this says something different and I still can't decipher what they truly mean, is there some spec on this?
| /// The `lite` mode will only remove files which are referenced in the `_delta_log` associagted | ||
| /// with `remove` action | ||
| #[default] | ||
| Lite, |
There was a problem hiding this comment.
Let's also expose the mode to python 😊
There was a problem hiding this comment.
Would you be up for adding this exposure after we merge? 😈
rtyler
force-pushed
the
feature/full-vacuum-engage
branch
from
c734263 to
bcd4960
Compare
rtyler
force-pushed
the
feature/full-vacuum-engage
branch
from
bcd4960 to
a868406
Compare
ion-elgreco
previously approved these changes
Apr 16, 2025
ion-elgreco
previously approved these changes
Apr 17, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
mschmo
reviewed
May 2, 2025
crates/core/src/operations/vacuum.rs
Outdated
| /// Type of Vacuum operation to perform | ||
| #[derive(Debug, Default, Clone, PartialEq)] | ||
| pub enum VacuumMode { | ||
| /// The `lite` mode will only remove files which are referenced in the `_delta_log` associagted |
There was a problem hiding this comment.
Obviously not a big deal, but "associagted" -> "associated"
rtyler
force-pushed
the
feature/full-vacuum-engage
branch
2 times, most recently
from
b5a9b0e to
9d2ffd8
Compare
This allows an optional but not-on-by-default mode of removing untracked files in the delta table directory. Delta/Spark supports a "lite" and "full" mode for [vacuum]. This change is intentionally not making "full" the default as it is for Delta/Spark since that may have unintended consequences for our users who have become accustomed to "lite" being the default. Fixes delta-io#2349 [vacuum]: https://docs.delta.io/latest/delta-utility.html#remove-files-no-longer-referenced-by-a-delta-table Signed-off-by: R. Tyler Croy <[email protected]>
rtyler
force-pushed
the
feature/full-vacuum-engage
branch
from
9d2ffd8 to
010fb04
Compare
ion-elgreco
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows an optional but not-on-by-default mode of removing untracked
files in the delta table directory. Delta/Spark supports a "lite" and
"full" mode for vacuum. This change is intentionally not making "full"
the default as it is for Delta/Spark since that may have unintended
consequences for our users who have become accustomed to "lite" being
the default.
Fixes #2349
Signed-off-by: R. Tyler Croy [email protected]