chore: reduce scope of feature flags and compilation requirements for subcrates #3409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The object_store crate does not require its cloud feature in order to use RetryConfig, so most of the subcrates can shed a cloud and datafusion feature. Cleaning this up allows for avoiding the ObjectStoreFactory trait's ambiguous implementation which can cause problem if a subcrate is implemented using the "non-cloud" arm but then is included in a dependency tree where the "cloud" feature is enabled by another dependency. This was sort of only theoretically possible but did manifest during `cargo publish` operations. Additionally the removal of a datafusion feature when it iis not necessary results in ~100 fewer crates at compile and link time for those (hi!) working within subcrates Signed-off-by: R. Tyler Croy <[email protected]>
rtyler
force-pushed
the
26.1-addl-improvements
branch
from
0ea2d20 to
91b7c51
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3409 +/- ##
==========================================
- Coverage 72.01% 72.00% -0.01%
==========================================
Files 148 148
Lines 46082 46081 -1
Branches 46082 46081 -1
==========================================
- Hits 33184 33181 -3
- Misses 10791 10792 +1
- Partials 2107 2108 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rtyler
requested review from
wjones127,
roeap,
hntd187 and
ion-elgreco
as code owners
ion-elgreco
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.