Skip to content

fix: drop column update #3416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025
Merged

fix: drop column update #3416

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eea2e21
fix: drop column earlier
ion-elgreco May 5, 2025
48fc909
Merge branch 'main' into fix/update_hidden_col
rtyler May 7, 2025
f38d00a
chore: add a regression test for #3413
rtyler May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: drop column earlier 
Signed-off-by: Ion Koutsouris <[email protected]>
  • Loading branch information
@ion-elgreco
ion-elgreco committed May 5, 2025
commit eea2e21b58eff271be754a0aeea8c2a8fcc70d0f
6 changes: 4 additions & 2 deletions crates/core/src/operations/update.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,9 @@ async fn execute(

//let updated_df = df_with_predicate_and_metrics.clone();
// Disabling the select allows the coerce test to pass, still not sure why
let updated_df = df_with_predicate_and_metrics.select(expressions.clone())?;
let updated_df = df_with_predicate_and_metrics
.select(expressions.clone())?
.drop_columns(&[UPDATE_PREDICATE_COLNAME])?;
let physical_plan = updated_df.clone().create_physical_plan().await?;
let writer_stats_config = WriterStatsConfig::new(
snapshot.table_config().num_indexed_cols(),
Expand All @@ -381,7 +383,7 @@ async fn execute(
.map(|v| v.iter().map(|v| v.to_string()).collect::<Vec<String>>()),
);

let tracker = CDCTracker::new(df, updated_df.drop_columns(&[UPDATE_PREDICATE_COLNAME])?);
let tracker = CDCTracker::new(df, updated_df);

let add_actions = write_execution_plan(
Some(&snapshot),
Expand Down
Loading