feat: spawn io with spawn service #3426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
requested review from
wjones127,
roeap,
rtyler and
hntd187
as code owners
ion-elgreco
force-pushed
the
feat-spawn-io
branch
from
9b1d26f to
8527565
Compare
ion-elgreco
force-pushed
the
feat-spawn-io
branch
4 times, most recently
from
335b49b to
9188c3e
Compare
|
I have pulled out the arrow pin to land separately to unblock other PRs 👍 I need to cut a release before this change lands because this is a breaking change and will require a bump to 0.27.x. I also need to read up a little bit more on the work you did with object_store to understand the purpose of the spawn service 🕵️ |
Signed-off-by: Ion Koutsouris <[email protected]>
Signed-off-by: Ion Koutsouris <[email protected]>
rtyler
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the superior spawn request connector over the deltaIOStoragebackend: https://github.com/apache/arrow-rs-object-store/pull/332/files#diff-3afe0961b5df6dc75c903371865daa9b80c8da3912c9b96df5b51613a5695335
Had to slightly refactor logstore_with and logstore_for to pass the StorageConfig around, which now can hold on the IORuntime directly, so that the
lakefsintegration and others can rebuild a new store with the same io_runtimeobject_storespawnService #3427