Skip to content

chore: minor table module refactors #3442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2025
Merged

chore: minor table module refactors #3442

merged 2 commits into from
May 17, 2025

Conversation

rtyler
Copy link
Member

@rtyler rtyler commented May 17, 2025

No description provided.

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label May 17, 2025
@rtyler rtyler marked this pull request as ready for review May 17, 2025 13:39
@rtyler rtyler enabled auto-merge May 17, 2025 13:39
roeap
roeap previously approved these changes May 17, 2025
View reviewed changes
Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ion-elgreco
ion-elgreco requested changes May 17, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented May 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.59140% with 32 lines in your changes missing coverage. Please review.

Project coverage is 71.92%. Comparing base (23f01ed) to head (7e05a3d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/table/checkpoint.rs 64.91% 20 Missing ⚠️
crates/core/src/table/columns.rs 65.71% 12 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3442      +/-   ##
==========================================
- Coverage   71.92%   71.92%   -0.01%     
==========================================
  Files         150      152       +2     
  Lines       46554    46544      -10     
  Branches    46554    46544      -10     
==========================================
- Hits        33485    33476       -9     
+ Misses      10917    10908       -9     
- Partials     2152     2160       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ion-elgreco ion-elgreco self-requested a review May 17, 2025 14:15
@rtyler
chore: refactor some symbols out of table/mod.rs into their own files
7e05a3d 
This makes things a little cleaner when reviewing this code and
preparing for refactors

Signed-off-by: R. Tyler Croy <[email protected]>
@rtyler rtyler requested a review from wjones127 as a code owner May 17, 2025 14:25
@github-actions github-actions bot added the binding/python Issues for the Python package label May 17, 2025
@rtyler rtyler added this pull request to the merge queue May 17, 2025
Merged via the queue into delta-io:main with commit 7392171 May 17, 2025
23 of 24 checks passed
@rtyler rtyler deleted the table-refactor branch May 17, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ion-elgreco ion-elgreco ion-elgreco approved these changes

@roeap roeap roeap left review comments

@hntd187 hntd187 Awaiting requested review from hntd187 hntd187 is a code owner

@wjones127 wjones127 Awaiting requested review from wjones127 wjones127 is a code owner

Assignees
No one assigned
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtyler @ion-elgreco @roeap