refactor: use LogStore in Snapshot / LogSegment APIs #3452
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving to kernel also means a significant change in our path handling. THus far we rely on object store's
Path
, often relative to the delta table root. In parctical terms this right now also hinders us from processing tables where data files are in different locations. More importantly though, kernel handles all path references as fully qualified URLs. As a pre-factor to further kernel adoption, we change the APIs for the internalSnapshots
andLogSegement
to useLogStore
.LogStore
carries a reference to the full table location and exposes a prefixed (to table root) as well as a non-prefixedObjectStore
along with kernelsEngine
. Tjis will allow us to have chanegs in functionality much more isolated in future PRs.This PR does not change an processing logic, and just defers the decision which store to use further into the stack.