Skip to content

chore: ensuring default builds work without datafusion #3453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025

Conversation

rtyler
Copy link
Member

@rtyler rtyler commented May 21, 2025

turns out our CI shouldn't have let some things through since it wasn't running a default build of tests too

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label May 21, 2025
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.72%. Comparing base (0b1c615) to head (40a9ebe).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3453      +/-   ##
==========================================
+ Coverage   71.70%   71.72%   +0.01%     
==========================================
  Files         152      152              
  Lines       46577    46577              
  Branches    46577    46577              
==========================================
+ Hits        33400    33408       +8     
+ Misses      11024    11022       -2     
+ Partials     2153     2147       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rtyler rtyler marked this pull request as ready for review May 22, 2025 12:46
Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rtyler rtyler added this pull request to the merge queue May 22, 2025
Merged via the queue into delta-io:main with commit 1cf629c May 22, 2025
21 checks passed
@rtyler rtyler deleted the default-build-tests branch May 22, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants