Skip to content

ci: add spellchecker to pr tests #3457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

ci: add spellchecker to pr tests #3457

merged 1 commit into from
May 23, 2025

Conversation

roeap
Copy link
Collaborator

@roeap roeap commented May 23, 2025

Description

I am notoriously bad at making my keyboard do the right things when it comes to spelling. As such I hope we can introduce a spellchecker into our CI.

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label May 23, 2025
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.71%. Comparing base (1cf629c) to head (a068f2e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3457      +/-   ##
==========================================
+ Coverage   71.70%   71.71%   +0.01%     
==========================================
  Files         152      152              
  Lines       46577    46577              
  Branches    46577    46577              
==========================================
+ Hits        33400    33405       +5     
+ Misses      11024    11022       -2     
+ Partials     2153     2150       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@roeap roeap enabled auto-merge May 23, 2025 12:26
@@ -367,7 +367,7 @@ mod tests {
async fn test_constraint_case_sensitive() -> DeltaResult<()> {
let arrow_schema = Arc::new(ArrowSchema::new(vec![
Field::new("Id", ArrowDataType::Utf8, true),
Field::new("vAlue", ArrowDataType::Int32, true),
Field::new("vAlue", ArrowDataType::Int32, true), // spellchecker:disable-line
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@roeap roeap added this pull request to the merge queue May 23, 2025
Merged via the queue into delta-io:main with commit 6b34d0f May 23, 2025
21 checks passed
@roeap roeap deleted the ci/spelling branch May 23, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants