refactor: remove pyarrow dependency #3459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
ion-elgreco
force-pushed
the
refactor/migrate-to-pyo3-arrow
branch
from
00cd58d to
2175e3c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3459 +/- ##
==========================================
- Coverage 71.72% 71.64% -0.08%
==========================================
Files 152 152
Lines 46577 46619 +42
Branches 46577 46619 +42
==========================================
- Hits 33407 33402 -5
- Misses 11024 11067 +43
- Partials 2146 2150 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ion-elgreco
changed the title
github-actions
bot
added
the
documentation
ion-elgreco
force-pushed
the
refactor/migrate-to-pyo3-arrow
branch
2 times, most recently
from
3277a9d to
76590d3
Compare
Signed-off-by: Ion Koutsouris <[email protected]>
ion-elgreco
force-pushed
the
refactor/migrate-to-pyo3-arrow
branch
from
76590d3 to
6f52fa6
Compare
roeap
reviewed
May 24, 2025
Comment on lines
+291
to
+298
| fn __arrow_c_schema__<'py>(&self, py: Python<'py>) -> PyArrowResult<Bound<'py, PyCapsule>> { | ||
| let inner_type = DataType::Array(Box::new(self.inner_type.clone())); | ||
| let arrow_type: ArrowDataType = (&inner_type) | ||
| .try_into() | ||
| .map_err(|err: ArrowError| PyException::new_err(err.to_string()))?; | ||
|
|
||
| to_schema_pycapsule(py, arrow_type) | ||
| } |
There was a problem hiding this comment.
SHould we maybe add a todo / issue to try and make this "only-once" copy with a OnceCell o.a. I think the capsule interface at least strongly encourages zero copy semantics. While thats harto to achieve, we can maybe get closer?
ion-elgreco
force-pushed
the
refactor/migrate-to-pyo3-arrow
branch
from
ba6d930 to
ed72d67
Compare
roeap
previously approved these changes
May 24, 2025
roeap
reviewed
May 24, 2025
.github/workflows/python_build.yml
Outdated
| name: Python Build (Python 3.10 PyArrow latest) | ||
| name: Python Build (Python 3.10 Optional latest pyarrow) |
There was a problem hiding this comment.
@ion-elgreco - maybe we need to revert this?
ion-elgreco
force-pushed
the
refactor/migrate-to-pyo3-arrow
branch
from
ed72d67 to
9ea1a4e
Compare
Signed-off-by: Ion Koutsouris <[email protected]>
ion-elgreco
force-pushed
the
refactor/migrate-to-pyo3-arrow
branch
from
9ea1a4e to
e1865b9
Compare
roeap
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactor makes pyarrow optional, and only used for the read paths. All data/schema interfaces are using arrow c data interfaces and return Arro3 RecordBatches or RecordBatchReaders (backed by arrow-rs <3). Even our own DeltaSchema can return PyCapsules now. Schema conversion code is also done with arro3, and the casting is done in Rust with a RecordBatchReader wrapper.
Related Issue(s)
Documentation
I will add this in a followup in the migration guide :)