test: improve storage config testing #3485
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3485 +/- ##
==========================================
+ Coverage 71.23% 71.35% +0.11%
==========================================
Files 149 149
Lines 44862 44932 +70
Branches 44862 44932 +70
==========================================
+ Hits 31959 32061 +102
+ Misses 10822 10798 -24
+ Partials 2081 2073 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roeap
force-pushed
the
test/extend-testing
branch
3 times, most recently
from
cd46235 to
61e6cb6
Compare
crates/core/Cargo.toml
Outdated
| @@ -95,6 +95,7 @@ maplit = "1" | |||
| sqlparser = { version = "0.56.0" } | |||
| humantime = { version = "2.1.0" } | |||
| validator = { version = "0.19", features = ["derive"] } | |||
| rstest = { version = "0.25.0", optional = true } | |||
There was a problem hiding this comment.
I'm not seeing a reason why this doesn't just get put into the [dev-dependencies] section, was there something that broke when that was done?
There was a problem hiding this comment.
I could revert this - the main thing is that we can export it under the integration_test feature, and use it in other crates.
There was a problem hiding this comment.
but turns out the way we are using it, it does no longer need to be a fixture ... will remove that.
Signed-off-by: Robert Pack <[email protected]>
roeap
force-pushed
the
test/extend-testing
branch
from
61e6cb6 to
fb69733
Compare
Description
On a mission to improve test coverage before the 1.0 release. Starting with storage config and object store registry. Also moving fixtures around a bit preparing for more testing ...
also includes one
cargo clippy.