Skip to content

ci: improve coverage collection #3497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

ci: improve coverage collection #3497

merged 1 commit into from
May 29, 2025

Conversation

roeap
Copy link
Collaborator

@roeap roeap commented May 29, 2025

Description

Trying to improve both the test coverage report and the test runtime.

  • collect coverage in:

    • integration-tests
    • integration-tests-lakefs
  • run python benchmark only on main

  • separate build checks from integration tests

  • run native tls tests in separate job

@roeap roeap requested a review from rtyler as a code owner May 29, 2025 12:15
Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.91%. Comparing base (48cf336) to head (77684bb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3497      +/-   ##
==========================================
+ Coverage   71.36%   73.91%   +2.55%     
==========================================
  Files         149      148       -1     
  Lines       44919    44401     -518     
  Branches    44919    44401     -518     
==========================================
+ Hits        32055    32818     +763     
+ Misses      10788     9449    -1339     
- Partials     2076     2134      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@roeap roeap force-pushed the test/coverage branch 3 times, most recently from 2c6f93d to 5988c7c Compare May 29, 2025 13:12
@github-actions github-actions bot added the ci label May 29, 2025
@roeap
Copy link
Collaborator Author

roeap commented May 29, 2025

@rtyler - it seems to be a bit quicker (unsurprisingly) since we are more parallel. We also collect more coverage in some of the sub-integration tests, so also got rid of teh dedicated coverage job.

I also added macos back to the test matrix. I do remember there was an issue, but I don't remember specifically what.

IF we adopt this, we should also update the required tests (e.g. new jobs - Unit Tests) should now be marked as required.

One caveat is that coverage reports will be updated as new reports are uploaded, which might be confusing to some folks, but this could be altered with some config.

@github-actions github-actions bot added the binding/python Issues for the Python package label May 29, 2025
Copy link
Member

@rtyler rtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's give it a whirl

@rtyler rtyler added this pull request to the merge queue May 29, 2025
Merged via the queue into delta-io:main with commit a31f241 May 29, 2025
29 checks passed
@roeap roeap deleted the test/coverage branch May 29, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants