fix: constraint parsing, roundtripping #3503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 89ddf07.
…eck will fail" This reverts commit 6babfb6.
Signed-off-by: Ion Koutsouris <[email protected]>
ion-elgreco
requested review from
wjones127,
roeap,
rtyler and
hntd187
as code owners
github-actions
bot
added
binding/python
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3503 +/- ##
==========================================
- Coverage 74.04% 74.00% -0.05%
==========================================
Files 148 148
Lines 44341 44335 -6
Branches 44341 44335 -6
==========================================
- Hits 32833 32810 -23
- Misses 9379 9383 +4
- Partials 2129 2142 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Ion Koutsouris <[email protected]>
roeap
reviewed
May 30, 2025
Signed-off-by: Ion Koutsouris <[email protected]>
roeap
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts #3374
The main issue was in the Display for SqlFormat, so when you would add constraints in delta-rs with backticks or quotes for columns with whitespaces, it wouldn't properly persist when it hits the metadata. The default display for
Expr::colis to use the flat name, but we should always usequoted_flat_name