fix(inspector): Preserve floating point precision from inspector response #1141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes denoland/deno#29059
Messages from the inspector that hold a number value can result in the loss of floating point precision when deserialized.
When a user sends
0.9999999999999999
in the REPL, V8 returns a RemoteObject that contains the field"value": 0.9999999999999999
. However, when it's deserialized intoserde_json::Value
here:deno_core/core/inspector.rs
Lines 883 to 884 in fc1ef37
value
becomesserde_json::Number(1.0)
, causing the REPL to print1
. Enabling thefloat_roundtrip
feature flag of serde json resolves this.Before:

After:
