Skip to content

Drop cooked-waker and improve MutableSleep implementation #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

paolobarbolini
Copy link
Contributor

This PR drops the cooked-waker dependency, which didn't seem to add any value to the project. While at it I've improved the MutableSleep implementation, making it a bit easier to review for unsafe, although more could be done in the future to make the usage of unsafe better.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.70%. Comparing base (0c7f83e) to head (141d891).
Report is 310 commits behind head on main.

Files with missing lines Patch % Lines
core/web_timeout.rs 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1151      +/-   ##
==========================================
+ Coverage   81.43%   81.70%   +0.26%     
==========================================
  Files          97      100       +3     
  Lines       23877    28957    +5080     
==========================================
+ Hits        19445    23660    +4215     
- Misses       4432     5297     +865     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants