Data sharks time shifting #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All charts ready and correctly displaying. They start with Afghanistan and an indicator that has no data, so that might be advisable to change. Also, added minor functionalities to norm.py and shift_corr.py, and started planning the test for all methods used in the time shift notebook (still pending the test itself).
…w-forge/python-data-driven-decisions into data-sharks-time-shifting
Confidence increased to 1 to keep the charts full, and X-axis of the second chart fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time shift notebook done. Charts working succesfully, although the inital values are for Afghanistan and an indicator with no data, so that might be advisable to be changed. Minor changes to both norm.py and shift_corr.py, and started planning the test for all methods used on the notebook. Test itself still pending.