feat(ldap): allow specifying multiple attributes on username input #4061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some use-cases, one would like to login using either their username or email. Administrators now don't have to choose a single field but may specify multiple fields to count as "username". This change is backwards-compatible. Signed-off-by: Yarden Shoham <[email protected]>
yardenshoham
force-pushed
the
multiple-username-attributes-ldap
branch
from
8ae1c73 to
8882c7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In some use cases, it may be desirable to log in using either a username or an email address. Administrators no longer need to select a single field and can specify multiple fields to be recognized as "username. "
What this PR does / why we need it
Changes the
userSearch.usernameto a comma-separated list of attributes.Special notes for your reviewer
This change is backward-compatible. Tests have been added.