chore: bump server apiVersion #4112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inline documentation states that apiVersion should be increased every time a new call is added to the API. Unfortunately, this process was not followed in dexidp#3598 where GetDiscovery API call was added. It also was not increased after adding GetClient in dexidp#2972. Signed-off-by: Marek Skrobacki <[email protected]>
skrobul
force-pushed
the
bump-api-version
branch
from
9388fd7 to
042452a
Compare
nabokihms
reviewed
May 12, 2025
There was a problem hiding this comment.
It was last time bumbed at 2017...
I'm not sure we need the version bump. Or if we do, we probably need a linter.
If there are clients who wants to know supported API methods, it is better to depend on a Dex version. Another way is to use a semver for the API version instead of the integer (we already have API tags, the latest is v2.3.0).
I think just bumping apiVersion will not bring us benefits we want.
@sagikazarmark wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Bumps
apiVersionso that API clients can correctly discover availability of a certain new API calls.What this PR does / why we need it
Inline documentation states that apiVersion should be increased every time a new call is added to the API. Unfortunately, this process was not followed in #3598 where GetDiscovery API call was added.
It also was not increased after adding GetClient in #2972.