doc(basic_bitcoin): add icp ninja link #1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpahlavi
reviewed
Jul 3, 2025
lpahlavi
approved these changes
Jul 3, 2025
mducroux
commented
Jul 4, 2025
|
|
||
| This example can be deployed directly to the Internet Computer using ICP Ninja, where it will connect to Bitcoin **testnet4**. | ||
|
|
||
| [](https://icp.ninja/editor?g=https://github.com/dfinity/examples/tree/master/rust/basic_bitcoin) |
There was a problem hiding this comment.
This points to the current master which does not include the latest change on dfx.json (namely adding init_arg). For the purpose of this review, dfx.json on ICP ninja needs to be modified to include init_arg.
kristoferlund
requested changes
Jul 4, 2025
There was a problem hiding this comment.
In order to support Ninja deployment, you need to have an init_arg. But README describes the process for local deployment where you instead specify network on deploy. This can become a little confusing.
I would suggest focusing the main branch on local deployment and then just creating a separate branch with the one line init_arg addition Ninja requires.
kristoferlund
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the
basic_bitcoinexampleREADME.md:get_block_headerscommand