Skip to content

Toggle the new Android prop diffing mechanism for components #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 0.78.0-discord
Choose a base branch
from
+7 −7
Draft

Toggle the new Android prop diffing mechanism for components #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<5de2cfc00f486b7d07266939ce18a397>>
* @generated SignedSource<<2b92c4d0536f4ce46db9c7a17d7e7469>>
*/

/**
Expand Down Expand Up @@ -65,7 +65,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

override fun enablePreciseSchedulingForPremountItemsOnAndroid(): Boolean = false

override fun enablePropsUpdateReconciliationAndroid(): Boolean = false
override fun enablePropsUpdateReconciliationAndroid(): Boolean = true

override fun enableReportEventPaintTime(): Boolean = false

Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<e38a0e9474ac349a4b8153862470c856>>
* @generated SignedSource<<054aa32e23061957eb17d1c98b3d4534>>
*/

/**
Expand Down Expand Up @@ -112,7 +112,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
}

bool enablePropsUpdateReconciliationAndroid() override {
return false;
return true;
}

bool enableReportEventPaintTime() override {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ const definitions: FeatureFlagDefinitions = {
},
},
enablePropsUpdateReconciliationAndroid: {
defaultValue: false,
defaultValue: true,
metadata: {
dateAdded: '2024-07-12',
description:
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<3037cf1c938dae492b656333cec9633c>>
* @generated SignedSource<<c77be228c968428738d0c8fea2a46af0>>
* @flow strict
*/

Expand Down Expand Up @@ -274,7 +274,7 @@ export const enablePreciseSchedulingForPremountItemsOnAndroid: Getter<boolean> =
/**
* When enabled, Android will receive prop updates based on the differences between the last rendered shadow node and the last committed shadow node.
*/
export const enablePropsUpdateReconciliationAndroid: Getter<boolean> = createNativeFlagGetter('enablePropsUpdateReconciliationAndroid', false);
export const enablePropsUpdateReconciliationAndroid: Getter<boolean> = createNativeFlagGetter('enablePropsUpdateReconciliationAndroid', true);
/**
* Report paint time inside the Event Timing API implementation (PerformanceObserver).
*/
Expand Down
Loading