-
-
Notifications
You must be signed in to change notification settings - Fork 649
Templatize _d_interface_cast
#21473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templatize _d_interface_cast
#21473
Conversation
Thanks for your pull request and interest in making D better, @Albert24GG! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#21473" |
a737250
to
47ff9c8
Compare
@thewilsonator please take a look at this when you can |
Not sure what you need to do to fix that. |
ee5f262
to
2ece573
Compare
ah, you need to also remove https://github.com/dlang/dmd/blob/master/druntime/mak/DOCS#L545 and possibly also the corresponding entry in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This otherwise is looking good
aef7d8c
to
675692d
Compare
This PR introduces the templatized version of
_d_interface_cast
, making_d_cast
the only hook used during lowering.I have added a small walkaround in
expressionsem.d
to still get the cast lowered correctly when some implicit casts are being made. This may not be ideal, but I am open to suggestions.I may also strip
rt/cast_.d
of unused functions, perhaps discarding the file completely.