Skip to content

fix #21504 - __traits(compiles) affects inference of @nogc in functions #21505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2025

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Jul 4, 2025

Adds test for isRootTraitsCompilesScope within setGC, so that a compile-time evaluation of a GC action does not alter the inferred attributes of a function and its function type.

Closes: #21504

…nctions

Adds test for `isRootTraitsCompilesScope` within `setGC`, so that a
compile-time evaluation of a GC action does not alter the inferred
attributes of a function and its function type.

Closes: dlang#21504
@dlang-bot
Copy link
Contributor

dlang-bot commented Jul 4, 2025

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#21505"

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue the fixes is a blocker for a PR that is to stable, are you intending to cherry-pick this, or do you want to target stable here?

@ibuclaw ibuclaw changed the base branch from master to stable July 5, 2025 05:36
@thewilsonator
Copy link
Contributor

Thanks!

@thewilsonator thewilsonator merged commit c3415e5 into dlang:stable Jul 5, 2025
43 of 46 checks passed
@ibuclaw ibuclaw deleted the issue21504 branch July 5, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__traits(compiles) affects inference of @nogc in functions
3 participants