camera_server: callback subscriptions for MAV_CMD_SET_CAMERA_MODE #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I keep the auto-generated commits and the implementation commits separate. So feel free to check the correct commit if you want less noise.
Added subscriptions to your camera_server plugin, where the user can provide callbacks for the three modes from MAV_CMD_SET_CAMERA_MODE (image / video / survey).
The reason for having three different subscriptions is that we can automatically deduce the capability flags of the camera, e.g.
check_modes_available
checks whether we already have more than one mode defined, in which case the flagCAMERA_CAP_FLAGS_HAS_MODES
gets added.We can do the same for zoom and focus.
Furthermore, I added the cam_definition_uri to the camera
Information
(as well as tried to match the field names inInformation
more closely to the corresponding mavlink message). This minor change already allows QGroundControl to display the camera interface: