Skip to content

Prerender precompile #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Prerender precompile #5

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9dafc28
feat(prerender): #000 prerender initial newtab page
Aug 23, 2016
dd39aea
Fix up DefinePlugin creation
dmose Sep 1, 2016
0cb1372
Get rid of unnecessary comments
dmose Sep 1, 2016
31d4743
Trial without RoutingContext
dmose Sep 1, 2016
bb19c7b
Use RouterContext on the pre-render
Sep 1, 2016
45e82aa
Only use fakeWindow in ReduxChannel if PRERENDERing
Sep 2, 2016
c765cb9
Make bundle:html use NODE_ENV=production again
Sep 2, 2016
b210aa0
Remove unused babel stuff
Sep 2, 2016
53d2b45
Add PRERENDER to eslintrc globals
Sep 2, 2016
b9c0e5e
Clean up hashHistory cruft
Sep 2, 2016
c2d049c
Nasty hack to make pre-rendered HTML match the dynamic stuff
Sep 6, 2016
d22c0a9
Fix eslint issues
Sep 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Trial without RoutingContext
  • Loading branch information
@dmose
dmose authored and Dan Mosedale committed Sep 6, 2016
commit 31d47433d017f3e4cc879e8316e3aa2e25697de2
14 changes: 9 additions & 5 deletions bin/generate-html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ const ReactDOMServer = require("react-dom/server");
const store = require("../content-src/store.js");

const {Provider} = require("react-redux");
const Routes = require("components/Routes/Routes");
const {RoutingContext} = require("components/Routes/Routes");
const NewTabPage = require("components/NewTabPage/NewTabPage");
const defaults = {
baseUrl: "",
title: "Loading...",
Expand All @@ -25,16 +26,19 @@ function template(rawOptions) {
console.error("before createClass");
const Root = React.createClass({
render() {
return (
<Provider store={store}>
<Routes />
const content = (
<Provider store={store}>
<NewTabPage />
</Provider>
);

console.error("content = ", content);
return content;
}
});

console.error("before string render");
const preRenderedContent = ReactDOMServer.renderToString(React.createElement(Root));
const preRenderedContent = ReactDOMServer.renderToString(<Root />);

console.error("before return");
return `<!doctype html>
Expand Down