Skip to content

fix: properly handle empty complex params #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

WiktorSobanski
Copy link

Improved handling of the complex parameters, namely picture_description_local and picture_description_api.
Sending empty values for these params resulted in 422 validation error, as empty value was parsed to empty string.

Now it handles the params correctly, sending these params can be omitted or sent as empty and the request will be valid.

@WiktorSobanski WiktorSobanski changed the title Fix/form data fix: properly handle empty complex params May 28, 2025
Copy link

mergify bot commented May 28, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@dolfim-ibm
Copy link
Contributor

Thanks for looking at this (very annoying, I know!) issue.

I was about to also have a deeper look at a solution, more thinking of some field_validator or similar.
What you propose here could be a backup solution, but it is very verbose and redundant. If possible I would like to avoid it.

@dolfim-ibm
Copy link
Contributor

Superseded by #210

@dolfim-ibm dolfim-ibm closed this Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants