Skip to content

DONT MERGE: Primeng 18 with Lara Theme #31321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
e123f51
Fix this
fmontes Feb 6, 2025
0eba1c1
refactor(primeng): Replace deprecated InputTextareaModule with Textar…
fmontes Feb 6, 2025
22f374d
refactor(primeng): Replace DynamicDialogModule with DynamicDialog
fmontes Feb 6, 2025
1325de0
refactor(primeng): Remove label prop from p-checkbox
fmontes Feb 6, 2025
41cc4f6
refactor(primeng): Improve checkbox and radio button accessibility an…
fmontes Feb 6, 2025
8a317ba
refactor(primeng): Replace ChipsModule with Chip in autocomplete tags…
fmontes Feb 6, 2025
bb91acf
refactor(primeng): Update DotAlertConfirmComponent method calls
fmontes Feb 6, 2025
cc8dc5f
clean up crazy cursor code
fmontes Feb 6, 2025
53c36e7
refactor(ui): Update UI components and styling with PrimeNG and Lato …
fmontes Feb 6, 2025
af7c76e
refactor(primeng): Update tabview classes to p-tabs in multiple compo…
fmontes Feb 6, 2025
216d0ef
Merge branch 'main' into primeng-ui
fmontes Feb 11, 2025
e3b1389
Merge branch 'main' into primeng-ui
fmontes Feb 12, 2025
323802a
Merge branch 'main' into primeng-ui
fmontes Feb 13, 2025
b902359
Merge branch 'main' into primeng-ui
fmontes Feb 18, 2025
e2f4b71
Merge branch 'main' into primeng-ui
fmontes Feb 24, 2025
e3641e4
Merge branch 'main' into primeng-ui
nicobytes Feb 25, 2025
813c636
Fix: Record Content-Type of Binary Fields Correctly in Events (#31451)
freddyDOTCMS Feb 25, 2025
5a3a106
#28422: Rebalancing ITs again part 2 (#31421)
victoralfaro-dotcms Feb 25, 2025
b479e58
fix(FTM): avoid executing ftm logic for immediate publish date in liv…
valentinogiardino Feb 25, 2025
c23fe90
#31452: removing fallback restore keys for release process (#31453)
victoralfaro-dotcms Feb 25, 2025
2d39404
fix(Page) Broken Assets Loading LIVE Mode Refs: #31402 (#31455)
fabrizzio-dotCMS Feb 25, 2025
07a4bee
refactor(data-access): Improve error message extraction in HTTP error…
nicobytes Feb 25, 2025
0993b83
fix(uve): Fixed iframeURL selector on store (#31470)
KevinDavilaDotCMS Feb 25, 2025
705603f
feat(Content Analytics) #31319 : Add telemetry customer category, cus…
jcastro-dotcms Feb 26, 2025
b2ad4d5
Script to report lead time to change for GH issues (#31479)
dsilvam Feb 26, 2025
4a31356
Issue 31420 datetool (#31447)
jdotcms Feb 26, 2025
db10cd7
Merge branch 'main' into primeng-ui
fmontes Feb 27, 2025
c03c528
Merge branch 'main' into primeng-ui
fmontes Feb 28, 2025
5b1bbc5
Merge branch 'main' into primeng-ui
fmontes Mar 3, 2025
c24a906
Merge branch 'main' into primeng-ui
fmontes Mar 6, 2025
a23153e
Merge branch 'main' into primeng-ui
fmontes Mar 7, 2025
567462b
Merge branch 'main' into primeng-ui
fmontes Mar 10, 2025
7927449
Merge branch 'main' into primeng-ui
fmontes Mar 12, 2025
f627339
Merge branch 'main' into primeng-ui
fmontes Mar 18, 2025
d8720a1
Merge branch 'main' into primeng-ui
fmontes Mar 25, 2025
9d03875
Merge branch 'main' into primeng-ui
fmontes Apr 1, 2025
0742a59
Merge branch 'main' into primeng-ui
fmontes Apr 4, 2025
cfb16a9
Merge branch 'main' into primeng-ui
fmontes Apr 9, 2025
43350f2
Merge branch 'main' into primeng-ui
fmontes Apr 21, 2025
c4c15f2
Merge branch 'main' into primeng-ui
fmontes Apr 24, 2025
2e1f1e0
Merge branch 'main' into primeng-ui
fmontes May 8, 2025
7269db9
Merge branch 'main' into primeng-ui
fmontes May 12, 2025
6a55c9a
Merge branch 'main' into primeng-ui
fmontes May 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(primeng): Replace DynamicDialogModule with DynamicDialog
  • Loading branch information
fmontes committed Feb 6, 2025
commit 22f374d8c136a0d32400574fbd9a535b33788f2d
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { NgModule } from '@angular/core';
import { ReactiveFormsModule } from '@angular/forms';

import { ButtonModule } from 'primeng/button';
import { DialogService, DynamicDialogModule } from 'primeng/dynamicdialog';
import { DialogService, DynamicDialog } from 'primeng/dynamicdialog';
import { MenuModule } from 'primeng/menu';
import { SkeletonModule } from 'primeng/skeleton';
import { TabViewModule } from 'primeng/tabview';
Expand All @@ -24,7 +24,7 @@ import { DotContentEditorComponent } from './dot-container-code.component';
DotMessagePipe,
ReactiveFormsModule,
ButtonModule,
DynamicDialogModule,
DynamicDialog,
DotAddVariableModule,
DotIconModule,
SkeletonModule,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { CommonModule } from '@angular/common';
import { NgModule } from '@angular/core';

import { ButtonModule } from 'primeng/button';
import { DialogService, DynamicDialogModule } from 'primeng/dynamicdialog';
import { DialogService, DynamicDialog } from 'primeng/dynamicdialog';

import { DotPortletBaseModule } from '@components/dot-portlet-base/dot-portlet-base.module';
import { DotApiLinkComponent, DotFieldRequiredDirective, DotMessagePipe } from '@dotcms/ui';
Expand All @@ -20,7 +20,7 @@ import { DotTemplatePropsModule } from './dot-template-props/dot-template-props.
DotPortletBaseModule,
DotTemplateCreateEditRoutingModule,
DotTemplatePropsModule,
DynamicDialogModule,
DynamicDialog,
DotMessagePipe,
DotFieldRequiredDirective,
DotTemplateBuilderModule
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ import { SharedModule } from 'primeng/api';
import { AutoFocusModule } from 'primeng/autofocus';
import { ButtonModule } from 'primeng/button';
import { CheckboxModule } from 'primeng/checkbox';
import { DialogService, DynamicDialogModule } from 'primeng/dynamicdialog';
import { DialogService, DynamicDialog } from 'primeng/dynamicdialog';
import { MenuModule } from 'primeng/menu';

import { DotActionButtonModule } from '@components/_common/dot-action-button/dot-action-button.module';
import { DotBulkInformationModule } from '@components/_common/dot-bulk-information/dot-bulk-information.module';
import { DotBulkInformationComponent } from '@components/_common/dot-bulk-information/dot-bulk-information.component';
import { DotEmptyStateModule } from '@components/_common/dot-empty-state/dot-empty-state.module';
import { DotListingDataTableModule } from '@components/dot-listing-data-table';
import { DotTemplatesService } from '@dotcms/app/api/services/dot-templates/dot-templates.service';
Expand Down Expand Up @@ -39,8 +39,8 @@ import { DotTemplateListComponent } from './dot-template-list.component';
DotActionButtonModule,
DotActionMenuButtonComponent,
DotAddToBundleComponent,
DynamicDialogModule,
DotBulkInformationModule,
DynamicDialog,
DotBulkInformationComponent,
DotBinaryOptionSelectorComponent,
DotEmptyStateModule,
AutoFocusModule
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,19 @@
import { CommonModule } from '@angular/common';
import { Component, OnInit } from '@angular/core';

import { DynamicDialogConfig, DynamicDialogRef } from 'primeng/dynamicdialog';
import { DynamicDialog, DynamicDialogConfig, DynamicDialogRef } from 'primeng/dynamicdialog';

import { DotActionBulkResult } from '@dotcms/dotcms-models';
import { DotMessagePipe } from '@dotcms/ui';

@Component({
selector: 'dot-bulk-information',
templateUrl: './dot-bulk-information.component.html',
styleUrls: ['./dot-bulk-information.component.scss']
styleUrls: ['./dot-bulk-information.component.scss'],
standalone: true,
imports: [CommonModule, DynamicDialog, DotMessagePipe]
})

export class DotBulkInformationComponent implements OnInit {
data: DotActionBulkResult;
constructor(
Expand Down

This file was deleted.

4 changes: 2 additions & 2 deletions core-web/libs/block-editor/src/lib/block-editor.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { FormsModule, ReactiveFormsModule } from '@angular/forms';
import { ConfirmationService } from 'primeng/api';
import { ConfirmDialogModule } from 'primeng/confirmdialog';
import { DialogModule } from 'primeng/dialog';
import { DynamicDialogModule } from 'primeng/dynamicdialog';
import { DynamicDialog } from 'primeng/dynamicdialog';
import { PaginatorModule } from 'primeng/paginator';
import { TextareaModule } from 'primeng/textarea';

Expand Down Expand Up @@ -58,7 +58,7 @@ const initTranslations = (dotMessageService: DotMessageService) => {
ReactiveFormsModule,
SharedModule,
PrimengModule,
DynamicDialogModule,
DynamicDialog,
AssetFormModule,
DotFieldRequiredDirective,
UploadPlaceholderComponent,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { AsyncPipe, NgClass, NgFor, NgIf, NgStyle } from '@angular/common';
import { NgModule } from '@angular/core';

import { DividerModule } from 'primeng/divider';
import { DialogService, DynamicDialogModule, DynamicDialogRef } from 'primeng/dynamicdialog';
import { DialogService, DynamicDialog, DynamicDialogRef } from 'primeng/dynamicdialog';
import { ToolbarModule } from 'primeng/toolbar';

import { DotContainersService } from '@dotcms/data-access';
Expand All @@ -18,7 +18,7 @@ import { TemplateBuilderComponent } from './components/template-builder/template
NgFor,
AsyncPipe,
DotMessagePipe,
DynamicDialogModule,
DynamicDialog,
NgStyle,
NgClass,
ToolbarModule,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { ChangeDetectionStrategy, Component } from '@angular/core';
import { FormsModule } from '@angular/forms';

import { ButtonModule } from 'primeng/button';
import { DynamicDialogConfig, DynamicDialogModule, DynamicDialogRef } from 'primeng/dynamicdialog';
import { DynamicDialogConfig, DynamicDialog, DynamicDialogRef } from 'primeng/dynamicdialog';

import { DotMessagePipe } from '../../dot-message/dot-message.pipe';

Expand All @@ -22,7 +22,7 @@ export interface BINARY_OPTION {
@Component({
selector: 'dot-binary-selector',
standalone: true,
imports: [FormsModule, DotMessagePipe, ButtonModule, DynamicDialogModule],
imports: [FormsModule, DotMessagePipe, ButtonModule, DynamicDialog],
templateUrl: './dot-binary-option-selector.component.html',
styleUrls: ['./dot-binary-option-selector.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush
Expand Down