feat(edit-content): add system timezone support to calendar field component #32142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please use a Conventional Commit title format for this PR. For more information, see https://www.conventionalcommits.org/en/v1.0.0/ |
…ponent This commit introduces a new interface and integrates timezone handling into the . Key changes include: - Added property to the interface. - Updated the calendar field component to display the system timezone label when applicable. - Enhanced the calendar field's HTML and TypeScript to support timezone adjustments for date inputs. - Refactored related utility functions to accommodate timezone logic. These updates improve the user experience by ensuring accurate date and time representation based on the configured system timezone.
oidacra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces timezone support for calendar fields and refactors related components to improve functionality and maintainability. Key updates include adding a system timezone configuration, enhancing the
DotEditContentCalendarFieldComponentwith timezone handling, and updating related utilities and interfaces to support the changes.Timezone Support Enhancements:
SystemTimezoneinterface and integrated it intoConfigParamsindotcms-config.service.tsto provide system timezone configuration. Updated theDotcmsConfigServiceto include the newsystemTimezoneproperty. [1] [2] [3]DotEditContentCalendarFieldComponentto handle timezone adjustments, including computing default dates and displaying timezone labels when applicable. Added utility methods for timezone conversion and adjusted the component's structure for better readability. [1]R1, [2] [3] [4]Component Refactoring:
DotEditContentFieldComponentandDotEditContentFormComponentto injectDotcmsConfigServiceand compute the system timezone as a reactive signal. Updated templates to pass the timezone to child components. [1] [2] [3] [4] [5] [6] [7]dot-edit-content-calendar-field.component.htmlto include hints and timezone labels dynamically based on the system timezone.Utility and Interface Updates:
CALENDAR_FIELD_TYPES_WITH_TIMEconstant to distinguish calendar field types that include time. Updated related utilities and constants accordingly. [1] [2] [3] [4]FormFieldValuetype to supportnumberfor better flexibility in form data handling.These changes collectively enhance the system's ability to handle timezones effectively while maintaining a clean and modular codebase.
Checklist
Additional Info
** any additional useful context or info **
Screenshots