Skip to content

Apply help to all symbols in the CLI declaration #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main-powderhouse
Choose a base branch
from
+117 −2
Open

Apply help to all symbols in the CLI declaration #2442

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
203c023
Apply help to all symbols in the CLI
Jun 13, 2024
fb6952a
Add HelpSubsystem tests
Jun 13, 2024
2408173
Removed code comment
Jun 13, 2024
63ae37a
Removed unnecessary not null check
hasnik Jun 18, 2024
577c60d
Removed unnecessary string interpolation on constant string value
hasnik Jun 18, 2024
f4a627a
Removed unnecessary not null check
hasnik Jun 18, 2024
141a74a
Removed unnecessary string interpolation on constant string value
hasnik Jun 18, 2024
93fb212
Removed unnecessary string interpolation on constant string value
hasnik Jun 18, 2024
910aa7e
Changed namespace declaration to file scoped
Jun 18, 2024
e028d1a
Consolided Help subsystem tests with same body
Jun 18, 2024
9a48fef
Removed mistakenly copied comment
Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed code comment
  • Loading branch information
Michał Haśnik committed Jun 13, 2024
commit 240817350b55a9734c0e3d46d1465777c03c8c5b
3 changes: 0 additions & 3 deletions src/System.CommandLine.Subsystems/HelpSubsystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ protected internal override void Initialize(InitializationContext context)
{
AddOptionRecursively(context.Configuration.RootCommand, HelpOption);

// I imagine this method should belong to CliCommand
// or some extensions method, but I didn't want to change
// too much in this PR without consulting you first
static void AddOptionRecursively(CliCommand command, CliOption option)
{
command.Add(option);
Expand Down