[WiP] Fix leak on Command Element #26044
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartyIX
added
platform/macos
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Nov 25, 2024
There was a problem hiding this comment.
The build is failing because there are some unit tests not passing:
Failed ReenabledAfterCommandRemoved [< 1 ms]
Error Message:
Assert.True() Failure
Expected: True
Actual: False
Failed RemovedCommandEnablesRefreshView [< 1 ms]
Error Message:
Assert.True() Failure
Expected: True
Actual: False
Could you review it? Let me know if can help with something.
4 tasks
pictos
force-pushed
the
pj/Icommand-element-leak
branch
from
8c68bb0 to
ecb9dd6
Compare
MartyIX
reviewed
Dec 14, 2024
Comment on lines
+49
to
+50
| ve.Unloaded -= OnUnloaded; | ||
| ve.Unloaded += OnUnloaded; |
There was a problem hiding this comment.
What is the idea behind this?
There was a problem hiding this comment.
safe code to avoid the same control to subscribe the same event more than once. But this will be reworked, this approach will not be used
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Closing in favor of #29837 29837 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PRs make sure that controls that implements
ICommandElementunsubscribe fromCommand.CanExecuteChangedevent avoid the control to leak if theCommandlives longer than it.Issues Fixed
Fixes #16124