[Testing] Migration of Compatibility.Core platform-specific unit tests into device tests - 6 #28399

nivetha-nagalingam · 2025-03-14T07:09:22Z

Description of Change
Migration of Compatibility.Core platform-specific unit tests to device tests. Here the migrated cases which ensuring that the Translation consistency of different elements matches their native counterparts. We are going to migrate tests in blocks in different PRs. This is the 6th group.

There are unit tests under:

src\Compatibility\Core\tests\Android
src\Compatibility\Core\tests\iOS
src\Compatibility\Core\tests\WinUI

That are not running right now. these cases from Xamarin.Forms where they could run as unit tests, but now with .NET MAUI this is not possible. So here I migrated the following cases in device tests.

https://github.com/dotnet/maui/blob/main/src/Compatibility/Core/tests/Android/TranslationTests.cs

This pull request introduces several new tests to ensure the consistency of the Translation property across various UI elements in the Android platform. The changes include adding new test cases and necessary imports for testing the Translation property.

New Tests for Translation Property Consistency:

BoxView:

https://github.com/dotnet/maui/blob/main/src/Controls/tests/DeviceTests/Elements/BoxView/BoxViewTests.Android.cs : Added a test to verify that the Translation property of a BoxView matches the native Translation.

Button:

https://github.com/dotnet/maui/blob/main/src/Controls/tests/DeviceTests/Elements/Button/ButtonTests.Android.cs : Added a test to ensure the Translation property of a Button is consistent with the native Translation.

CheckBox:

https://github.com/dotnet/maui/blob/main/src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.Android.cs : Added a test to check that the Translation property of a CheckBox aligns with the native Translation.

Editor:

https://github.com/dotnet/maui/blob/main/src/Controls/tests/DeviceTests/Elements/Editor/EditorTests.Android.cs : Added a test to confirm that the Translation property of an Editor corresponds with the native Translation.

Entry:

https://github.com/dotnet/maui/blob/main/src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.Android.cs : Added a test to validate that the Translation property of an Entry matches the native Translation.

Label:

https://github.com/dotnet/maui/blob/main/src/Controls/tests/DeviceTests/Elements/Label/LabelTests.Android.cs : Added a test to validate that the Translation property of an Label matches the native Translation.

SearchBar:

https://github.com/dotnet/maui/blob/main/src/Controls/tests/DeviceTests/Elements/SearchBar/SearchBarTests.Android.cs: Added a test to validate that the Translation property of an SearchBar matches the native Translation.

SwipeView:

https://github.com/dotnet/maui/blob/main/src/Controls/tests/DeviceTests/Elements/SwipeView/SwipeViewTests.Android.cs : Added a test to validate that the Translation property of an SwipeView matches the native Translation.

These changes ensure that the Translation properties of different UI elements are accurately tested against their native counterparts, improving the reliability of the UI framework.

Issues Fixed
Fixes #27303

dotnet-policy-service · 2025-03-14T07:09:49Z

Hey there @nivetha-nagalingam! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copilot

Pull Request Overview

This PR migrates platform-specific unit tests for verifying the Translation property consistency from Xamarin.Forms to .NET MAUI device tests on Android.

Introduces new device tests for Translation consistency for BoxView, Button, CheckBox, Editor, Entry, Label, SearchBar, and SwipeView.
Ensures that the native Translation values of these controls match the expected pixel values calculated using the device’s display density.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/Controls/tests/DeviceTests/Elements/BoxView/BoxViewTests.Android.cs	Added test for BoxView Translation consistency
src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.Android.cs	Added test for Entry Translation consistency
src/Controls/tests/DeviceTests/Elements/Label/LabelTests.Android.cs	Added test for Label Translation consistency
src/Controls/tests/DeviceTests/Elements/SearchBar/SearchBarTests.Android.cs	Added test for SearchBar Translation consistency
src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.Android.cs	Added test for CheckBox Translation consistency
src/Controls/tests/DeviceTests/Elements/Editor/EditorTests.Android.cs	Added test for Editor Translation consistency
src/Controls/tests/DeviceTests/Elements/SwipeView/SwipeViewTests.Android.cs	Added test for SwipeView Translation consistency
src/Controls/tests/DeviceTests/Elements/Button/ButtonTests.Android.cs	Added test for Button Translation consistency

src/Controls/tests/DeviceTests/Elements/BoxView/BoxViewTests.Android.cs

src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.Android.cs

src/Controls/tests/DeviceTests/Elements/Label/LabelTests.Android.cs

src/Controls/tests/DeviceTests/Elements/SearchBar/SearchBarTests.Android.cs

src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.Android.cs

src/Controls/tests/DeviceTests/Elements/Editor/EditorTests.Android.cs

src/Controls/tests/DeviceTests/Elements/SwipeView/SwipeViewTests.Android.cs

src/Controls/tests/DeviceTests/Elements/Button/ButtonTests.Android.cs

jsuarezruiz · 2025-03-14T09:01:51Z

/azp run

azure-pipelines · 2025-03-14T09:02:14Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho

I think the Copilot review is correct here, can we use some kind of helper so we don t repeat this code everywhere..

var translation = nativeView.TranslationX;
var density = Microsoft.Maui.Devices.DeviceDisplay.Current.MainDisplayInfo.Density;
var expectedInPixels = density * boxView.TranslationX;

Assert.Equal(expectedInPixels, translation, 1.0);

var translationY = nativeView.TranslationY;
var expectedYInPixels = density * boxView.TranslationY;
Assert.Equal(expectedYInPixels, translationY, 1.0);

jsuarezruiz · 2025-03-17T08:32:54Z

/azp run

azure-pipelines · 2025-03-17T08:33:14Z

Azure Pipelines successfully started running 3 pipeline(s).

nivetha-nagalingam · 2025-03-17T09:18:31Z

I think the Copilot review is correct here, can we use some kind of helper so we don t repeat this code everywhere..

@rmarinho, I’ve added the helper method in the recent commit. Kindly share your thoughts.

jsuarezruiz · 2025-03-27T10:42:10Z

@nivetha-nagalingam Could you rebase and fix conflicts? Thanks in advance.

nivetha-nagalingam · 2025-03-27T12:01:55Z

@nivetha-nagalingam Could you rebase and fix conflicts? Thanks in advance.

@jsuarezruiz , I have rebased and resolved the conflicts.

jsuarezruiz · 2025-03-28T09:06:54Z

/azp run

azure-pipelines · 2025-03-28T09:07:16Z

Azure Pipelines successfully started running 3 pipeline(s).

PureWeen

Fix merge conflicts

nivetha-nagalingam · 2025-04-02T03:13:29Z

Fix merge conflicts

@PureWeen, I have rebased and resolved the conflicts.

jsuarezruiz · 2025-04-16T14:39:06Z

/azp run

azure-pipelines · 2025-04-16T14:39:29Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-04-23T11:52:46Z

/azp run

azure-pipelines · 2025-04-23T11:53:05Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-05-16T05:57:42Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-16T05:57:54Z

Azure Pipelines successfully started running 1 pipeline(s).

…s into device tests - 6 (#28399) * Enabled the translation property for device tests * Added the helper method * Reverted the changes * Updated EditorTests.Android.cs * Fix formating

dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Mar 14, 2025

nivetha-nagalingam added the area-testing Unit tests, device tests label Mar 14, 2025

nivetha-nagalingam marked this pull request as ready for review March 14, 2025 07:16

Copilot AI review requested due to automatic review settings March 14, 2025 07:16

nivetha-nagalingam requested a review from a team as a code owner March 14, 2025 07:16

nivetha-nagalingam requested review from jfversluis and mattleibow March 14, 2025 07:16

Copilot AI reviewed Mar 14, 2025

View reviewed changes

jsuarezruiz previously approved these changes Mar 14, 2025

View reviewed changes

rmarinho requested changes Mar 14, 2025

View reviewed changes

nivetha-nagalingam dismissed jsuarezruiz’s stale review via 9d9c11e March 17, 2025 08:03

jsuarezruiz previously approved these changes Mar 18, 2025

View reviewed changes

anandhan-rajagopal requested a review from rmarinho March 19, 2025 02:13

nivetha-nagalingam force-pushed the Enabled-translation-property-devicetest-1403 branch from 9d9c11e to 344b604 Compare March 27, 2025 11:12

nivetha-nagalingam dismissed jsuarezruiz’s stale review via 55f54b5 March 27, 2025 11:26

nivetha-nagalingam force-pushed the Enabled-translation-property-devicetest-1403 branch from 55f54b5 to 1febfb2 Compare March 27, 2025 11:57

PureWeen requested changes Mar 28, 2025

View reviewed changes

nivetha-nagalingam force-pushed the Enabled-translation-property-devicetest-1403 branch from 1febfb2 to 6572c46 Compare April 1, 2025 05:18

jsuarezruiz previously approved these changes Apr 25, 2025

View reviewed changes

anandhan-rajagopal requested a review from PureWeen April 28, 2025 16:50

nivetha-nagalingam added 4 commits May 14, 2025 13:03

Enabled the translation property for device tests

097b927

Added the helper method

5458b3c

Reverted the changes

e7dab42

Updated EditorTests.Android.cs

b449c4f

nivetha-nagalingam dismissed jsuarezruiz’s stale review via b449c4f May 14, 2025 07:34

nivetha-nagalingam force-pushed the Enabled-translation-property-devicetest-1403 branch from 1f13873 to b449c4f Compare May 14, 2025 07:34

Fix formating

12c9c16

jsuarezruiz approved these changes May 16, 2025

View reviewed changes

PureWeen changed the base branch from main to inflight/current June 24, 2025 22:15

PureWeen merged commit 92be210 into dotnet:inflight/current Jun 24, 2025
78 checks passed

[Testing] Migration of Compatibility.Core platform-specific unit tests into device tests - 6 #28399

[Testing] Migration of Compatibility.Core platform-specific unit tests into device tests - 6 #28399

Uh oh!

Conversation

nivetha-nagalingam commented Mar 14, 2025

New Tests for Translation Property Consistency:

Uh oh!

dotnet-policy-service bot commented Mar 14, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jsuarezruiz commented Mar 14, 2025

Uh oh!

azure-pipelines bot commented Mar 14, 2025

Uh oh!

rmarinho left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Mar 17, 2025

Uh oh!

azure-pipelines bot commented Mar 17, 2025

Uh oh!

nivetha-nagalingam commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsuarezruiz commented Mar 27, 2025

Uh oh!

nivetha-nagalingam commented Mar 27, 2025

Uh oh!

jsuarezruiz commented Mar 28, 2025

Uh oh!

azure-pipelines bot commented Mar 28, 2025

Uh oh!

PureWeen left a comment

Choose a reason for hiding this comment

Uh oh!

nivetha-nagalingam commented Apr 2, 2025

Uh oh!

jsuarezruiz commented Apr 16, 2025

Uh oh!

azure-pipelines bot commented Apr 16, 2025

Uh oh!

jsuarezruiz commented Apr 23, 2025

Uh oh!

azure-pipelines bot commented Apr 23, 2025

Uh oh!

jsuarezruiz commented May 16, 2025

Uh oh!

azure-pipelines bot commented May 16, 2025

Uh oh!

Uh oh!

Uh oh!

rmarinho left a comment •

edited

Loading

nivetha-nagalingam commented Mar 17, 2025 •

edited

Loading