[Windows] Fixed Shell flyout background image does not displayed #28977
Conversation
|
Hey there @@SubhikshaSf4851! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| } | ||
|
|
||
| var service = provider.GetRequiredImageSourceService(imageSource); | ||
| var nativeImageSource = await service.GetImageSourceAsync(imageSource); |
There was a problem hiding this comment.
if nativeImageSource is null at this point, can directly set the pane background to null.
There was a problem hiding this comment.
I have updated the requested changes
SubhikshaSf4851
force-pushed
the
fix-21472
branch
from
c5ab0b6 to
fa90415
Compare
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SubhikshaSf4851
force-pushed
the
fix-21472
branch
from
fa90415 to
c5ab0b6
Compare
| { | ||
| public Issue21472ContentPage() | ||
| { | ||
| Content = new Label |
There was a problem hiding this comment.
To cover all the scenarios, could this be replaced by a Button and tapping it set the FlyoutBackgroundImage to null? In this way, with the test we can verify that we can set the background image and also remove it.
There was a problem hiding this comment.
I have modified the test sample as per your suggestion
SubhikshaSf4851
force-pushed
the
fix-21472
branch
from
c5ab0b6 to
258a93b
Compare
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
||
| [Test, Order(2)] | ||
| [Category(UITestCategories.Shell)] | ||
| public void VerifyShellFlyoutBackgroundImageSetNull() |
There was a problem hiding this comment.
Pending snapshot on Mac and Windows. Available in the latest build.
There was a problem hiding this comment.
Pending Snapshots were added.
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
) * [Windows] Fix for FlyoutBackgroundImage * [Windows] Fix for Flyout Background Image * Test case sample for FlyoutBackgroundImage * [Windows] Fix for FlyoutBackgroundImage * [Windows] Fix for FlyoutBackgroundImage * Updated Test sample * Changed test sample and added snapshots for android and iOS * BackgroundImage set Snapshot for windows and mac * BackgroundImage set Null Snapshot for windows and mac
Root Cause :
The FlyoutBackgroundImage and FlyoutBackgroundImageAspect were not implemented in Shell, resulting in the Flyout background image not being rendered on the Windows platform.
Description of Change:
I have implemented the necessary mappers for FlyoutBackgroundImage and FlyoutBackgroundImageAspect, updated them, and resolved the issue
Tested the behaviour in the following platforms
Issue Fixed:
Fixes #21472
Screenshot