Skip to content

Fixed Test case failure in PR 29335 - [2025/05/12] Candidate #29352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

Fixed Test case failure in PR 29335 - [2025/05/12] Candidate #29352

merged 1 commit into from
May 6, 2025

Conversation

LogishaSelvarajSF4525
Copy link
Contributor

@LogishaSelvarajSF4525 LogishaSelvarajSF4525 commented May 6, 2025 •
edited
Loading

Description

This pull request includes changes aimed at resolving test failures observed in the Candidate PR(#29335) the ItemTemplate in CollectionViewViewModel to improve readability by using explicit layout creation. It also updates the snapshot to reflect changes in GroupHeader font size.

Changes Description:

  • We modified the font size for the group header and item template in the shared ViewModel class for the Feature Matrix file in a previously merged PR. This change caused a screenshot validation failure. To resolve it, we resaved the affected images and reverted the template change to maintain consistency across other feature test scenarios.

@LogishaSelvarajSF4525 LogishaSelvarajSF4525 requested a review from a team as a code owner May 6, 2025 10:03
@LogishaSelvarajSF4525 LogishaSelvarajSF4525 requested review from mattleibow and rmarinho and removed request for a team May 6, 2025 10:03
@LogishaSelvarajSF4525 LogishaSelvarajSF4525 added area-testing Unit tests, device tests partner/syncfusion Issues / PR's with Syncfusion collaboration labels May 6, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @@LogishaSelvarajSF4525! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label May 6, 2025
@rmarinho rmarinho merged commit 53f75da into dotnet:inflight/candidate May 6, 2025
1 check passed
SuthiYuvaraj pushed a commit to SuthiYuvaraj/maui that referenced this pull request May 9, 2025
@LogishaSelvarajSF4525 @SuthiYuvaraj
updated changes (dotnet#29352)
6e4229a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@mattleibow mattleibow Awaiting requested review from mattleibow mattleibow is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@PureWeen PureWeen Awaiting requested review from PureWeen

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz

Assignees
No one assigned
Labels
area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration test-flight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LogishaSelvarajSF4525 @rmarinho @anandhan-rajagopal