[Testing] Re-Enabled UI Test - Issue12574Test #29436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@TamilarasanSF4853! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
There was a problem hiding this comment.
Pull Request Overview
This PR refines the test case for Issue12574 by replacing manual scrolling with programmatic swiping, enhancing test robustness and platform independence.
- Replaces App.ScrollRight calls with App.Tap on a new swipe button in the shared test code.
- Adds a new swipe button and updates the layout and event handling in the host app to support the improved test flow.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/CarouselViewUITests.LoopNoFreeze.cs | Replaced manual swipe gestures with tapping on a dedicated swipe button. |
| src/Controls/tests/TestCases.HostApp/Issues/CarouselViewLoopNoFreeze.cs | Added a new swipe button, updated grid layout, and introduced a CurrentPosition property in the view model to manage carousel swiping. |
src/Controls/tests/TestCases.HostApp/Issues/CarouselViewLoopNoFreeze.cs
Outdated
Show resolved
Hide resolved
…Freeze.cs Co-authored-by: Copilot <[email protected]>
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
approved these changes
May 19, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2025
* re-enabled the test for android * modified test case * Update src/Controls/tests/TestCases.HostApp/Issues/CarouselViewLoopNoFreeze.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2025
* re-enabled the test for android * modified test case * Update src/Controls/tests/TestCases.HostApp/Issues/CarouselViewLoopNoFreeze.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request addresses improvements to a test case for Issue 12574 by refining the test logic, enhancing user interaction handling, and removing a platform-specific exclusion directive. The changes aim to make the test more robust and platform-independent.
Issue
Previously, the test was experiencing intermittent failures (flakiness) on Android because scrolling in the carousel view items wasn't working consistently in CI. As a result, the test case was failing continuously on the Android platform.
Solution
Since this test was added to verify that the CarouselView freezes on iOS, we used programmatic scrolling instead of manual scrolling to preserve the intent of the original test case.
Fixes #28760 (Issue12574Test)