-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[Testing] Added UITest for MenuFlyoutItem Clicked/Command delegate #29604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PureWeen
merged 3 commits into
dotnet:inflight/current
from
anandhan-rajagopal:fix-20718
May 22, 2025
Merged
[Testing] Added UITest for MenuFlyoutItem Clicked/Command delegate #29604
PureWeen
merged 3 commits into
dotnet:inflight/current
from
anandhan-rajagopal:fix-20718
May 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces new UI tests to verify the functionality of MenuFlyoutItem commands on both Mac Catalyst and Windows, addressing Issue #20685.
- Added a shared NUnit test class to verify the execution of clicked events, commands, and commands with parameters.
- Added a HostApp test case that sets up a MenuBarItem with MenuFlyoutItems wired to display appropriate result messages.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20685.cs | Contains NUnit tests ensuring that the MenuFlyoutItem events and commands are triggered and update the UI correctly. |
src/Controls/tests/TestCases.HostApp/Issues/Issue20685.cs | Defines a UI test page configuring MenuBarItem and MenuFlyoutItems with the required event and command handlers. |
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20685.cs
Outdated
Show resolved
Hide resolved
…685.cs Co-authored-by: Copilot <[email protected]>
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
approved these changes
May 22, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2025
…29604) * Added test cases to ensure menuflyoutitem commands * code optimization * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20685.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2025
…29604) * Added test cases to ensure menuflyoutitem commands * code optimization * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20685.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-testing
Unit tests, device tests
community ✨
Community Contribution
partner/syncfusion
Issues / PR's with Syncfusion collaboration
testing-missing-tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request addresses Issue #20685, which concerns
MenuBarItem
commands not functioning correctly on Mac Catalyst. It introduces a new test case to validate the behavior ofMenuFlyoutItem
commands and their interactions.Additions to test cases for Issue #20685:
New UI Test for Mac Catalyst and Windows:
Issue20685
inTestCases.HostApp
to reproduce the issue by implementing aMenuBarItem
with three types ofMenuFlyoutItem
commands: a clicked event, a command, and a command with a parameter.Automated Test cases:
Issue20685
inTestCases.Shared.Tests
with NUnit tests to verify the functionality of theMenuFlyoutItem
commands on supported desktop platforms (Mac Catalyst and Windows). These tests include:Clicked
event handler execution.Issues Fixed
Fixes #20718