Skip to content

[Inflight/Current] Fix Build issue in inflight/Current #29614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bhavanesh2001
Copy link
Contributor

Fixes build error caused by mixed nullability handling from PRs #28568 and #29557

cc @PureWeen

@bhavanesh2001 bhavanesh2001 requested a review from a team as a code owner May 21, 2025 19:58
@bhavanesh2001 bhavanesh2001 requested review from PureWeen and tj-devel709 and removed request for a team May 21, 2025 19:58
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label May 21, 2025
@PureWeen
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@bhavanesh2001
Copy link
Contributor Author

PushingNavigationPageModallyWithShellShowsToolbarCorrectly fails with API23 #29557 (comment).
Screenshot 2025-05-22 at 6 15 31 AM

Is it okay if i add a delay in the test?

// Verify that new navigation bar can gain a back button
var secondModalPage = new ContentPage();
await modalPage.Navigation.PushAsync(secondModalPage);

@PureWeen PureWeen merged commit 16de14d into dotnet:inflight/current May 22, 2025
118 of 130 checks passed
github-actions bot pushed a commit that referenced this pull request May 22, 2025
github-actions bot pushed a commit that referenced this pull request May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community ✨ Community Contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants