Fix CarouselView PreviousPosition updating when inserting items #29617
+137
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@Shalini-Ashokan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
added
the
area-controls-collectionview
jsuarezruiz
requested changes
May 26, 2025
| // Updates position to match current item when inserting items, correctly tracking previous position values. | ||
| if (currentItemPosition != carouselPosition && ItemsView.ItemsUpdatingScrollMode == ItemsUpdatingScrollMode.KeepItemsInView) | ||
| { | ||
| if (InitialPositionSet && currentItemPosition > -1) |
There was a problem hiding this comment.
Can nest this two conditions in a single one, but would be better to create a variable to increase the readability:
var shouldUpdatePosition =
currentItemPosition != carouselPosition &&
ItemsView.ItemsUpdatingScrollMode == ItemsUpdatingScrollMode.KeepItemsInView &&
InitialPositionSet &&
currentItemPosition > -1;
There was a problem hiding this comment.
@jsuarezruiz, I have updated the code section based on your suggestions.
| Margin = new Thickness(20), | ||
| }; | ||
|
|
||
| insertButton.Clicked += (sender, e) => |
There was a problem hiding this comment.
Could include another button to remove the current item and verify the PositionChanged event parameter?
There was a problem hiding this comment.
@jsuarezruiz, I have included the test case for the remove action.
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Details
In the CarouselView control, when items are added at index 0, the PreviousPosition property in the PositionChangedEventArgs does not update correctly.
Root Cause
When items are inserted at index 0, explicitly setting the position to the current item position (currentItemPosition) prevents the actual position from changing. As a result, the PositionChanged event is not triggered, and PreviousPosition remains incorrect.
Description of Change
To correctly update the position and trigger the PositionChanged event, it update the PreviousPosition value correctly.
Validated the behavior in the following platforms
Issues Fixed
Fixes #29524
Output ScreenShot
29524-BeforeFix.mov
29524-AfterFix.mov