[.NET 10] [iOS] Fixed: Switch OffColor resets after minimizing and reopening the app #29771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
community ✨
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue on iOS and Mac where the Switch OffColor resets when the app is minimized and reopened.
- Added NSNotification observers to update the switch track color when the app returns to the foreground.
- Updated the Disconnect method to remove the observers, preventing potential memory leaks.
- Introduced test cases to validate the restoration of the OffColor after the app lifecycle events.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Core/src/Handlers/Switch/SwitchHandler.iOS.cs | Added observers to reapply OffColor on app foreground events and updated disconnect logic |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29768.cs | Added test case verifying switch OffColor restoration after app reopening |
| src/Controls/tests/TestCases.HostApp/Issues/Issue29768.cs | Added UI test page to support issue 29768 testing |
Comment on lines
+86
to
+92
| void UpdateTrackOffColor(UISwitch platformView) | ||
| { | ||
| DispatchQueue.MainQueue.DispatchAsync(async () => | ||
| { | ||
| if (!platformView.On) | ||
| { | ||
| await Task.Delay(10); // Small delay, necessary to allow UIKit to complete its internal layout and styling processes before re-applying the custom color |
There was a problem hiding this comment.
[nitpick] Consider extracting the delay value '10' into a named constant to improve maintainability and clarify its purpose.
Suggested change
| void UpdateTrackOffColor(UISwitch platformView) | |
| { | |
| DispatchQueue.MainQueue.DispatchAsync(async () => | |
| { | |
| if (!platformView.On) | |
| { | |
| await Task.Delay(10); // Small delay, necessary to allow UIKit to complete its internal layout and styling processes before re-applying the custom color | |
| const int UIKitStylingDelayMilliseconds = 10; // Small delay to allow UIKit to complete internal layout and styling processes | |
| void UpdateTrackOffColor(UISwitch platformView) | |
| { | |
| DispatchQueue.MainQueue.DispatchAsync(async () => | |
| { | |
| if (!platformView.On) | |
| { | |
| await Task.Delay(UIKitStylingDelayMilliseconds); |
Copilot uses AI. Check for mistakes.
|
How does this relates to #29694 ? |
@rmarinho, this change is not directly related to #29694, as it addresses a different issue. Issue #29694 concerns the default On color not being retained, whereas this change fixes a problem where the Off color is not retained when the app is minimized and reopened |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
bhavanesh2001
suggested changes
Jun 5, 2025
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Root Cause of the issue
Description of Change
Issues Fixed
Fixes #29768
Tested the behaviour in the following platforms
Screenshot
Before-Fix-iOS.mov
After-Fix-iOS.mov
Before-Fix-Mac.mov
After-Fix-Mac.mov