Skip to content

[iOS] Device tests - html label #29906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Jun 10, 2025

Description of Change

This Pr fixes these test failures
Screenshot 2025-06-10 at 17 56 38

We need to delay here because platformLabel.UpdateTextHtml(label) and label.InvalidateMeasure() are dispatched asynchronously to the main thread and may not complete immediately.
The changes were introduced in this PR: #26153

@kubaflo kubaflo requested a review from a team as a code owner June 10, 2025 15:56
@kubaflo kubaflo requested review from jfversluis and mattleibow and removed request for a team June 10, 2025 15:56
@kubaflo kubaflo self-assigned this Jun 10, 2025
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jun 10, 2025
Copy link
Contributor

Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@rmarinho
Copy link
Member

/rebase

@jsuarezruiz
Copy link
Contributor

@kubaflo Could you fix the conflicts? Thanks in advance.

@kubaflo kubaflo changed the base branch from inflight/current to inflight/candidate June 11, 2025 13:25
@kubaflo
Copy link
Contributor Author

kubaflo commented Jun 11, 2025

@jsuarezruiz I had to change the base branch. Should be good now

@kubaflo kubaflo force-pushed the fix-29886-2 branch 2 times, most recently from e5955bc to 0223ff2 Compare June 11, 2025 14:23
@github-actions github-actions bot force-pushed the inflight/candidate branch from a9ad676 to a653ab0 Compare June 11, 2025 16:12
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@sheiksyedm
Copy link
Contributor

@kubaflo It seems that you have brought in inflight/current branch changes into this PR, which has resulted in more changes than expected

@kubaflo
Copy link
Contributor Author

kubaflo commented Jun 13, 2025

@sheiksyedm thanks for letting me know

@PureWeen
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen merged commit 0ae18a8 into dotnet:inflight/candidate Jun 16, 2025
118 of 130 checks passed
PureWeen added a commit that referenced this pull request Jun 21, 2025
For more information about inflight process check
https://github.com/dotnet/maui/wiki/Inflight-Branch-Process

# .NET MAUI Release Notes - inflight/candidate Branch

## MAUI Product Fixes
* [iOS] Fix SwipeView programmatic open when background color is set by
@Shalini-Ashokan in #29765
* [iOS] FormattedText with text color causes stack overflow - fix by
@kubaflo in #29874
* [iOS] Fix AdaptiveTrigger not working as expected by @jsuarezruiz in
#20987
* [iOS] Fix for Flyout title is not broken over multiple lines when you
rotate your screen by @BagavathiPerumal in
#29171
* [Windows] Fix for Assigning null to the SelectedItem of the
CollectionView in the SelectionChanged event does not clear the
selection by @SyedAbdulAzeemSF4852 in
#29288
* Fix TapCoordinates method in Catalyst by @jsuarezruiz in
#29775
* Fixed ItemSpacing on CarouselView resizes items [Android] by
@Dhivya-SF4094 in #29796
* Perf : ButtonContentTypeConverter now using InvariantCulture to parse
double by @antoine-jonathan in #25393
* ToolbarItem behavior with ImageSource iOS - fix by @kubaflo in
#28833
* [Android] Fixed Button Shadow Color Transparency Not Applied Correctly
by @NanthiniMahalingam in #29371
* Don't call NSAttributedString with HTML from a background thread by
@kubaflo in #26153
* [Windows] Implemented the Resize and Downsize functions in the
W2DImage class by @HarishwaranVijayakumar in
#29138
* Templated indicator view - improvements by @kubaflo in
#25642
* Update Issue25946.xaml by @anandhan-rajagopal in
#30025

## Testing
* Fixed Test case failure in PR 26153 - iOS by @kubaflo in
#29906
* Fixed Test case failure in PR 25642 - snapshots by @kubaflo in
#29881
* [Testing] Feature Matrix UITest Cases for RadioButton by
@TamilarasanSF4853 in #29744
* [Testing] Feature Matrix UITest Cases for CollectionView ItemsSource
Feature by @LogishaSelvarajSF4525 in
#29322
* [Testing] Feature Matrix UITest Cases for Stepper by
@nivetha-nagalingam in #29731
* [Testing] Feature Matrix UITest Cases for CheckBox Control by
@anandhan-rajagopal in #29739
* Update the comment for the test properties by @mattleibow in
#27306

## Dependency Updates
* No changes in this category

## Docs
* No changes in this category

## Housekeeping
* [create-pull-request] automated change by @github-actions[bot] in
#29875
* [create-pull-request] automated change by @github-actions[bot] in
#29792
* [create-pull-request] automated change by @github-actions[bot] in
#29760

**Full Changelog**:
origin/main...origin/inflight/candidate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing Unit tests, device tests community ✨ Community Contribution needs-area-label platform/ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants