Fix Picker ItemDisplayBinding doesn't support MVVM properly #29922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@devanathan-vaithiyanathan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
MartyIX
reviewed
Jun 11, 2025
MartyIX
reviewed
Jun 11, 2025
MartyIX
reviewed
Jun 11, 2025
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25634.cs
Outdated
Show resolved
Hide resolved
MartyIX
reviewed
Jun 11, 2025
MartyIX
reviewed
Jun 11, 2025
MartyIX
reviewed
Jun 11, 2025
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
requested changes
Jun 12, 2025
| { | ||
| App.WaitForElement("PickerButton"); | ||
| App.Tap("PickerButton"); | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Pending snapshot in all the platforms. Already available in the latest build.
Could you commit the images?
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
requested changes
Jun 12, 2025
@jsuarezruiz , pending snapshots has been added. |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
reviewed
Jun 16, 2025
| @@ -264,6 +264,27 @@ static void OnItemsSourceChanged(BindableObject bindable, object oldValue, objec | |||
|
|
|||
| void OnItemsSourceChanged(IList oldValue, IList newValue) | |||
| { | |||
| if (oldValue is not null) | |||
There was a problem hiding this comment.
This logic is duplicated, can extract it to a method.
There was a problem hiding this comment.
Inside the methods, check items.Count == 0 before iterating to avoid unnecessary loops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Details
Picker does not refresh displayed item when bound property changes through ItemDisplayBinding
Description of Change
Added support to automatically refresh the Picker display when a bound item's property changes. Subscribed to property change events in the items source, and updated the display when the property defined in ItemDisplayBinding changes. Also handled item additions and removals by updating the subscriptions accordingly.
Issues Fixed
Fixes #25634
Tested the behavior in the following platforms.
iOS-BeforeFix.mov
iOS-AfterFix.mov