-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS] Fixed Flyout icon not updating when root page changes using InsertPageBefore #29924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[iOS] Fixed Flyout icon not updating when root page changes using InsertPageBefore #29924
Conversation
Hey there @@Vignesh-SF3580! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
{ | ||
App.WaitForElement("InsertPageButton"); | ||
App.Tap("InsertPageButton"); | ||
VerifyScreenshot(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsuarezruiz I have updated the pending snapshots for Mac and Windows.
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
Issue Detail
When using the InsertPageBefore method to change the root page in a NavigationPage, the back button is not visible, but the flyout icon remains visible.
Root Cause
The flyout icon was not updated when changing the root page using InsertPageBefore.
Description of Change
The updated logic checks whether the inserted page becomes the new root, updates the flyout icon. Previously, the flyout icon was updated based on NavPageController.Pages. However, this collection was not updated with the actual native navigation stack. Since pages are inserted directly into ViewControllers in InsertPageBefore, the fix updates the flyout icon based on the ViewControllers stack instead.
Tested the behavior in the following platforms
Issues Fixed
Fixes #29921
Screenshots
iOSBeforeFixInsertpage.mov
iOSAfterFixInsertPage.mov