-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Windows] Fix Flyout Page SetCollapseStyle doesn't have any change #29927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Windows] Fix Flyout Page SetCollapseStyle doesn't have any change #29927
Conversation
Hey there @@devanathan-vaithiyanathan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
@@ -0,0 +1,29 @@ | |||
# if TEST_FAILS_ON_ANDROID && TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_IOS // It's a Windows specific API issue, so restricting the other platforms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because is a platform specific, here can use directly #if WINDOWS
. Are not failing on other platforms, just have not sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsuarezruiz , Thanks for pointing out. I have modified the changes
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue details
FlyoutPage on Windows did not update its layout when the CollapseStyle property changed at runtime.
Description of Change
This update enables dynamic support for the CollapseStyle property in FlyoutPage on Windows. It allows the flyout pane to update at runtime when the property changes,
Issues Fixed
Fixes #18200
Tested the behavior in the following platforms.
Without-Fix.mp4
With-Fix.mp4