[Android] Add defensive not null check to SearchHandlerAppearanceTracker.FocusChange #29939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if _editText is null before detaching the event.
|
Hey there @@Transis-Felipe! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
added
platform/android
area-controls-shell
jsuarezruiz
reviewed
Jun 12, 2025
| @@ -270,6 +270,9 @@ protected virtual void Dispose(bool disposing) | |||
| if (_searchHandler != null) | |||
| { | |||
| _searchHandler.PropertyChanged -= SearchHandlerPropertyChanged; | |||
| } | |||
| if (_editText != null) | |||
There was a problem hiding this comment.
LGTM! Did you find a related issue? Can you describe the steps to reproduce it? I'd like to include a relevant test with the changes.
There was a problem hiding this comment.
@jsuarezruiz No, I don't find a direct issue related to this.
I was just investigating to see if I can find the reason of other leaks and found this.
It's just a defensive check to ensure that the _editText is not null before attempting to remove it from the FocusChange event.
Transis-Felipe
changed the title
Transis-Felipe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if _editText is null before detaching the event.