[inflight/current] Update public API #29947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the public API definitions to streamline integration with main and reduce merge complexity.
- Public API signatures have been updated by adding new members and removing deprecated ones across multiple platform-specific API files.
- Several additions in shipped files and removals in unshipped files may have breaking implications if not paired with proper documentation and test case updates.
Reviewed Changes
Copilot reviewed 276 out of 276 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Controls/src/Core/PublicAPI/net-windows/PublicAPI.Shipped.txt | Added new public API members (e.g., UpdateSourceEventName setter). |
| src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Unshipped.txt | Removed several public API members in unshipped Tizen API. |
| src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Shipped.txt | Added new public API members and updated existing ones. |
| src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt | Removed multiple public API members specific to Mac Catalyst. |
Comments suppressed due to low confidence (3)
src/Controls/src/Core/PublicAPI/net-windows/PublicAPI.Shipped.txt:810
- The addition of a new public API member (UpdateSourceEventName setter) may introduce breaking changes. Please verify that these changes are fully documented and that appropriate test cases are added.
+~Microsoft.Maui.Controls.Internals.TypedBindingBase.UpdateSourceEventName.set -> void
src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Shipped.txt:1192
- Updating the public API by adding a generic SetAndCreateSource method could be a breaking change. Ensure that the API documentation is updated and corresponding tests are provided.
+~Microsoft.Maui.Controls.ResourceDictionary.SetAndCreateSource<T>(System.Uri value) -> void
src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt:2
- The removal of this public API member is a breaking change. Please ensure that any deprecation strategy is documented and that related test cases are updated accordingly.
-Microsoft.Maui.Controls.StyleableElement.Style.get -> Microsoft.Maui.Controls.Style?
rmarinho
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just updates the public API so the merge to main is les crazy.