Skip to content

Removed SearchHandler Style Definitions #29955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NirmalKumarYuvaraj
Copy link
Contributor

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue details

The defined style for SearchHandler is not propagated to the SearchHandler

Root cause

SearchHandler is not derived from VisualElement, so the style is not propagated to it.

Description of Change

Removed the SearchHandler style definitions from the following files.

Issues Fixed

Fixes #6972

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jun 12, 2025
Copy link
Contributor

Hey there @@NirmalKumarYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jun 12, 2025
@NirmalKumarYuvaraj NirmalKumarYuvaraj marked this pull request as ready for review June 12, 2025 12:27
@Copilot Copilot AI review requested due to automatic review settings June 12, 2025 12:27
@NirmalKumarYuvaraj NirmalKumarYuvaraj requested a review from a team as a code owner June 12, 2025 12:27
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the unused SearchHandler style definitions from two styles files, addressing the issue that the SearchHandler style was not being applied due to its base type.

  • Removed SearchHandler style definitions from the multiproject and mobile resource styles.
  • Aligns the code with the intended UI behavior by eliminating ineffective style code.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Templates/src/templates/maui-multiproject/MauiApp.1/Resources/Styles/Styles.xaml Removed SearchHandler style block
src/Templates/src/templates/maui-mobile/Resources/Styles/Styles.xaml Removed SearchHandler style block
Comments suppressed due to low confidence (2)

src/Templates/src/templates/maui-multiproject/MauiApp.1/Resources/Styles/Styles.xaml:286

  • Ensure that the removal of the SearchHandler style is reflected in the public documentation (*.xml files in /docs/) to keep the docs aligned with the behavior changes.
<Style TargetType="SearchHandler">

src/Templates/src/templates/maui-mobile/Resources/Styles/Styles.xaml:318

  • Ensure that the removal of the SearchHandler style is reflected in the public documentation (*.xml files in /docs/) to keep the docs aligned with the behavior changes.
<Style TargetType="SearchHandler">

@jsuarezruiz jsuarezruiz added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label Jun 13, 2025
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styles don't propagate to SearchHandler
2 participants