Removed SearchHandler Style Definitions #29955
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@NirmalKumarYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
There was a problem hiding this comment.
Pull Request Overview
This PR removes the unused SearchHandler style definitions from two styles files, addressing the issue that the SearchHandler style was not being applied due to its base type.
- Removed SearchHandler style definitions from the multiproject and mobile resource styles.
- Aligns the code with the intended UI behavior by eliminating ineffective style code.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Templates/src/templates/maui-multiproject/MauiApp.1/Resources/Styles/Styles.xaml | Removed SearchHandler style block |
| src/Templates/src/templates/maui-mobile/Resources/Styles/Styles.xaml | Removed SearchHandler style block |
Comments suppressed due to low confidence (2)
src/Templates/src/templates/maui-multiproject/MauiApp.1/Resources/Styles/Styles.xaml:286
- Ensure that the removal of the SearchHandler style is reflected in the public documentation (*.xml files in /docs/) to keep the docs aligned with the behavior changes.
<Style TargetType="SearchHandler">
src/Templates/src/templates/maui-mobile/Resources/Styles/Styles.xaml:318
- Ensure that the removal of the SearchHandler style is reflected in the public documentation (*.xml files in /docs/) to keep the docs aligned with the behavior changes.
<Style TargetType="SearchHandler">
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue details
The defined style for SearchHandler is not propagated to the SearchHandler
Root cause
SearchHandler is not derived from VisualElement, so the style is not propagated to it.
Description of Change
Removed the SearchHandler style definitions from the following files.
src/Templates/src/templates/maui-mobile/Resources/Styles/Styles.xaml: TheSearchHandlerstyle, including text color, placeholder color, background color, font settings, and visual state management, was removed.src/Templates/src/templates/maui-multiproject/MauiApp.1/Resources/Styles/Styles.xaml: TheSearchHandlerstyle, with similar properties, was removed from this file as well.Issues Fixed
Fixes #6972