[Testing] Fix for flaky device test BlazorWebViewUsesStartPath on Windows #29966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@anandhan-rajagopal! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mattleibow
reviewed
Jun 12, 2025
| { | ||
| throw new InvalidOperationException("WebView2 runtime is not installed."); | ||
| } | ||
| await wv2.EnsureCoreWebView2Async(); |
There was a problem hiding this comment.
Isn't this called by the handler already?
There was a problem hiding this comment.
@mattleibow Yes, it was invoked in the handler already. However, the test failed in CI with the error 'Waited 30000ms but couldn't get CoreWebView2 to be available'. To address this, the call was added again to explicitly ensure proper initialization before the test begins, along with appropriate exception handling.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes flaky device tests for BlazorWebView on Windows by ensuring the WebView2 runtime is available and initialized before proceeding with the tests.
- Adds a check for the WebView2 runtime availability using CoreWebView2Environment.GetAvailableBrowserVersionString.
- Calls EnsureCoreWebView2Async when the CoreWebView2 instance is not yet available.
mattleibow
approved these changes
Jun 23, 2025
PureWeen
pushed a commit
that referenced
this pull request
Jun 25, 2025
…dows (#29966) * Update WebViewHelpers.Windows.cs * Update WebViewHelpers.Windows.cs * Update src/BlazorWebView/tests/MauiDeviceTests/WebViewHelpers.Windows.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jun 26, 2025
…dows (#29966) * Update WebViewHelpers.Windows.cs * Update WebViewHelpers.Windows.cs * Update src/BlazorWebView/tests/MauiDeviceTests/WebViewHelpers.Windows.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
PureWeen
pushed a commit
that referenced
this pull request
Jun 27, 2025
…dows (#29966) * Update WebViewHelpers.Windows.cs * Update WebViewHelpers.Windows.cs * Update src/BlazorWebView/tests/MauiDeviceTests/WebViewHelpers.Windows.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
PureWeen
pushed a commit
that referenced
this pull request
Jun 28, 2025
…dows (#29966) * Update WebViewHelpers.Windows.cs * Update WebViewHelpers.Windows.cs * Update src/BlazorWebView/tests/MauiDeviceTests/WebViewHelpers.Windows.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jun 29, 2025
…dows (#29966) * Update WebViewHelpers.Windows.cs * Update WebViewHelpers.Windows.cs * Update src/BlazorWebView/tests/MauiDeviceTests/WebViewHelpers.Windows.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jun 29, 2025
…dows (#29966) * Update WebViewHelpers.Windows.cs * Update WebViewHelpers.Windows.cs * Update src/BlazorWebView/tests/MauiDeviceTests/WebViewHelpers.Windows.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
…dows (#29966) * Update WebViewHelpers.Windows.cs * Update WebViewHelpers.Windows.cs * Update src/BlazorWebView/tests/MauiDeviceTests/WebViewHelpers.Windows.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
…dows (#29966) * Update WebViewHelpers.Windows.cs * Update WebViewHelpers.Windows.cs * Update src/BlazorWebView/tests/MauiDeviceTests/WebViewHelpers.Windows.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
…dows (#29966) * Update WebViewHelpers.Windows.cs * Update WebViewHelpers.Windows.cs * Update src/BlazorWebView/tests/MauiDeviceTests/WebViewHelpers.Windows.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
…dows (#29966) * Update WebViewHelpers.Windows.cs * Update WebViewHelpers.Windows.cs * Update src/BlazorWebView/tests/MauiDeviceTests/WebViewHelpers.Windows.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
…dows (#29966) * Update WebViewHelpers.Windows.cs * Update WebViewHelpers.Windows.cs * Update src/BlazorWebView/tests/MauiDeviceTests/WebViewHelpers.Windows.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 9, 2025
…dows (#29966) * Update WebViewHelpers.Windows.cs * Update WebViewHelpers.Windows.cs * Update src/BlazorWebView/tests/MauiDeviceTests/WebViewHelpers.Windows.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the flakiness observed in Blazor device tests, particularly the recurring error:
Build Link: https://dev.azure.com/xamarin/public/_build/results?buildId=143779&view=ms.vss-test-web.build-test-results-tab&runId=4309282&resultId=100000&paneView=debug
Root Cause
The failure is due to the WebView2 runtime not being available or failing to initialize in certain test environments. This is not related to the test logic but rather a system setup issue—specifically, the runtime dependency on a Windows GUI environment with WebView2 support.
Solution Description
Solution added
WaitForWebViewReadymethod inWebViewHelpers.Windows.csto ensure that the WebView2 runtime is properly installed and initialized before proceeding. The key change adds a check for the WebView2 runtime and initializes it if necessary.